new resource `azurerm_stack_hci_network_interface` #26888

teowa · 2024-07-31T13:50:21Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

new resource azurerm_stack_hci_network_interface
swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2024-01-01/networkInterfaces.json
azure doc: https://learn.microsoft.com/en-us/azure-stack/hci/manage/create-network-interfaces?tabs=azurecli

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccStackHCINetworkInterface_dynamic (510.08s)
--- PASS: TestAccStackHCINetworkInterface_complete (547.78s)
--- PASS: TestAccStackHCINetworkInterface_update (763.11s)
--- PASS: TestAccStackHCINetworkInterface_requiresImport (1010.17s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/azurestackhci 1010.193s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

new resource azurerm_stack_hci_network_interface

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…m into stackhci_network_interface

teowa · 2024-10-22T10:14:28Z

log

ms-zhenhua

Hi @teowa,

Thanks for this PR - I've taken a look through and left some minor comments inline. If we can fix those up, this should be good to go 👍

ms-zhenhua · 2024-10-24T07:08:01Z

internal/services/azurestackhci/stack_hci_network_interface_resource.go

+			ForceNew: true,
+			ValidateFunc: validation.StringMatch(
+				regexp.MustCompile(`^[a-zA-Z0-9][\-\.\_a-zA-Z0-9]{0,78}[a-zA-Z0-9]$`),
+				"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphen, dot and underline",


Suggested change

"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphen, dot and underline",

"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with alphanumberic characters.",

ms-zhenhua · 2024-10-24T07:22:51Z

internal/services/azurestackhci/stack_hci_network_interface_resource_test.go

+
+type StackHCINetworkInterfaceResource struct{}
+
+func TestAccStackHCINetworkInterface_dynamic(t *testing.T) {


why not name it basic ?

ms-zhenhua · 2024-10-24T07:27:15Z

website/docs/r/stack_hci_network_interface.html.markdown

+
+* `location` - (Required) The Azure Region where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.
+
+* `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.


Suggested change

* `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.

* `custom_location_id` - (Required) The ID of the Custom Location where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.

ms-zhenhua · 2024-10-24T07:28:58Z

website/docs/r/stack_hci_network_interface.html.markdown

+
+* `id` - The resource ID of the Azure Stack HCI Network Interface.
+
+* `ip_configuration` - A `ip_configuration` as defined below.


Suggested change

* `ip_configuration` - A `ip_configuration` as defined below.

* `ip_configuration` - An `ip_configuration` as defined below.

teowa · 2024-10-24T08:12:59Z

Hi @ms-zhenhua , thanks for reviewing. I have updated the code, please take another look.

ms-zhenhua

Hi @teowa,

Thank you for your updates. LGTM~

katbyte · 2024-11-05T19:30:53Z

website/docs/r/stack_hci_network_interface.html.markdown

+
+* `mac_address` - (Optional) The MAC address of the Network Interface. Changing this forces a new resource to be created.
+
+-> **Note:** If `mac_address` is not specified, it will be assigned by the server. If you experience a diff you may need to add this to `ignore_changes`.


is there a reason we do not make this computed so the user doesn't have to ue ignore changes?

From the contribute doc,

In order to solve this, (new) fields should no longer be marked as Optional + Computed - instead where a split Create and Update method is used (see above) users can lean on ignore_changes to ignore values from a field with a default value, should they wish to continue using the default value.

seems we are supposed to avoid optional+computed for new field.

…m into stackhci_network_interface

WodansSon · 2024-11-07T05:21:02Z

internal/services/azurestackhci/stack_hci_network_interface_resource.go

+			ForceNew: true,
+			ValidateFunc: validation.StringMatch(
+				regexp.MustCompile(`^[a-zA-Z0-9][\-\.\_a-zA-Z0-9]{0,78}[a-zA-Z0-9]$`),
+				"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with an alphanumberic character.",


Would something like this be more clear?

Suggested change

"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with an alphanumberic character.",

"name must begin and end with an alphanumeric character, be between 2 and 80 characters in length and can only contain alphanumeric characters, hyphens, periods or underscores.",

@teowa, sorry I forgot to add the description to my review. I took a look a think this mostly LGTM. If we can get the validation function error message fixed up I think this would be GTG! 🚀

Thanks for reviewing this, the code is updated, please kindly take another look.

…m into stackhci_network_interface

WodansSon

Hi @teowa,

Thanks for pushing those changes! I have given the PR another look at this LGTM now! 🚀

teowa added 5 commits July 9, 2024 07:56

new resource stack_hci_network_interface

fcf1d99

Merge branch 'main' of github.com:hashicorp/terraform-provider-azurer…

be6bdcc

…m into stackhci_network_interface

fix create/update

d12234a

Merge branch 'main' of github.com:hashicorp/terraform-provider-azurer…

8fd31c1

…m into stackhci_network_interface

fix tests

5562ab4

github-actions bot added documentation service/azure-stack-hci size/XL labels Jul 31, 2024

teowa marked this pull request as draft July 31, 2024 13:51

github-actions bot added the waiting-response label Jul 31, 2024

fix test

1256aae

github-actions bot removed the waiting-response label Aug 5, 2024

rcskosir added the new-resource label Oct 14, 2024

teowa added 2 commits October 22, 2024 07:41

Merge branch 'main' of github.com:hashicorp/terraform-provider-azurer…

9a5327f

…m into stackhci_network_interface

fix test

a9773d2

teowa force-pushed the stackhci_network_interface branch from be19ff0 to a9773d2 Compare October 22, 2024 09:58

github-actions bot added the waiting-response label Oct 22, 2024

fix lint

001e95d

github-actions bot removed the waiting-response label Oct 22, 2024

ms-zhenhua suggested changes Oct 24, 2024

View reviewed changes

github-actions bot added the waiting-response label Oct 24, 2024

fix doc and validation error message

813b457

github-actions bot removed the waiting-response label Oct 24, 2024

fix validation message

c880b37

ms-zhenhua approved these changes Oct 24, 2024

View reviewed changes

fix message

fed7d97

teowa marked this pull request as ready for review October 24, 2024 08:35

teowa requested a review from katbyte as a code owner October 24, 2024 08:35

teowa requested a review from a team as a code owner October 24, 2024 08:35

katbyte requested changes Nov 5, 2024

View reviewed changes

katbyte added the waiting-response label Nov 5, 2024

Merge branch 'main' of github.com:hashicorp/terraform-provider-azurer…

6712bf8

…m into stackhci_network_interface

github-actions bot removed the waiting-response label Nov 6, 2024

WodansSon requested changes Nov 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Nov 7, 2024

teowa added 2 commits November 7, 2024 05:37

Merge branch 'main' of github.com:hashicorp/terraform-provider-azurer…

a36ee66

…m into stackhci_network_interface

fix name validation error message

297f961

github-actions bot removed the waiting-response label Nov 7, 2024

teowa added 2 commits November 7, 2024 05:46

also fix other resources

a0ffca3

fix for virtual disk

77ace71

WodansSon approved these changes Nov 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource `azurerm_stack_hci_network_interface` #26888

new resource `azurerm_stack_hci_network_interface` #26888

teowa commented Jul 31, 2024

teowa commented Oct 22, 2024 •

edited

Loading

ms-zhenhua left a comment

ms-zhenhua Oct 24, 2024 •

edited

Loading

teowa Oct 24, 2024

ms-zhenhua Oct 24, 2024

teowa Oct 24, 2024

ms-zhenhua Oct 24, 2024

teowa Oct 24, 2024

ms-zhenhua Oct 24, 2024

teowa Oct 24, 2024

teowa commented Oct 24, 2024

ms-zhenhua left a comment

katbyte Nov 5, 2024

teowa Nov 6, 2024

WodansSon Nov 7, 2024

WodansSon Nov 7, 2024

teowa Nov 7, 2024

WodansSon left a comment •

edited

Loading

	"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphen, dot and underline",
	"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with alphanumberic characters.",


		type StackHCINetworkInterfaceResource struct{}

		func TestAccStackHCINetworkInterface_dynamic(t *testing.T) {


		* `location` - (Required) The Azure Region where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.

		* `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Network Interface should exist. Changing this forces a new resource to be created.


		* `id` - The resource ID of the Azure Stack HCI Network Interface.

		* `ip_configuration` - A `ip_configuration` as defined below.

	* `ip_configuration` - A `ip_configuration` as defined below.
	* `ip_configuration` - An `ip_configuration` as defined below.


		* `mac_address` - (Optional) The MAC address of the Network Interface. Changing this forces a new resource to be created.

		-> Note: If `mac_address` is not specified, it will be assigned by the server. If you experience a diff you may need to add this to `ignore_changes`.

	"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with an alphanumberic character.",
	"name must begin and end with an alphanumeric character, be between 2 and 80 characters in length and can only contain alphanumeric characters, hyphens, periods or underscores.",

new resource azurerm_stack_hci_network_interface #26888

Are you sure you want to change the base?

new resource azurerm_stack_hci_network_interface #26888

Conversation

teowa commented Jul 31, 2024

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

teowa commented Oct 22, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

ms-zhenhua Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teowa commented Oct 24, 2024

ms-zhenhua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon left a comment • edited Loading

Choose a reason for hiding this comment

new resource `azurerm_stack_hci_network_interface` #26888

new resource `azurerm_stack_hci_network_interface` #26888

teowa commented Oct 22, 2024 •

edited

Loading

ms-zhenhua Oct 24, 2024 •

edited

Loading

WodansSon left a comment •

edited

Loading