Improve unmarshalling for binary payloads #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
bugfix/resp-model-unmarshaling
branch
2 times, most recently
from
c3c532c
to
82db788
Compare
manicminer
force-pushed
the
bugfix/resp-model-unmarshaling
branch
from
82db788
to
c5efc6b
Compare
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
tombuildsstuff
approved these changes
Feb 20, 2024
| @@ -59,6 +59,10 @@ func (c ServeCommand) Run(args []string) int { | |||
| serviceNames = pointer.To(strings.Split(serviceNamesRaw, ",")) | |||
| } | |||
|
|
|||
| if logLevel := strings.TrimSpace(os.Getenv("PANDORA_LOG")); logLevel != "" { | |||
There was a problem hiding this comment.
I've not made the change to the Data API yet, but the other tools are now using LOG_LEVEL fwiw, probably worth doing that here too:
Suggested change
| if logLevel := strings.TrimSpace(os.Getenv("PANDORA_LOG")); logLevel != "" { | |
| if logLevel := strings.TrimSpace(os.Getenv("LOG_LEVEL")); logLevel != "" { |
(in the other tools this is done in main.go - but that's a minor nit we can clear up later if needed)
There was a problem hiding this comment.
Ah cool, I will align it with the rest of the tooling 👍
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the double pointer workaround for unmarshaling binary payloads into a
[]byte.Needs coordination with corresponding base layer PR: hashicorp/go-azure-sdk#890