Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binary unmarshalling and support per-request RetryFuncs #890

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Feb 20, 2024

This change needs coordinating with a corresponding Pandora PR: hashicorp/pandora#3826

@manicminer manicminer requested a review from a team as a code owner February 20, 2024 11:51
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Feb 20, 2024
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one missed import, but otherwise LGTM!

@@ -9,14 +9,14 @@ import (
"encoding/json"
"encoding/xml"
"fmt"
"github.com/hashicorp/go-azure-helpers/lang/pointer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import needs sorted here

@manicminer manicminer merged commit d241b54 into main Feb 23, 2024
5 checks passed
@manicminer manicminer deleted the f/binary-unmarshaling branch February 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants