Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use solo version for fst-chart-version by default #67

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Feb 25, 2024

Description

This pull request changes the following:

  • allow user to set fst-chart-version during solo init
  • use empty string for fst-chart-version to let solo fetch the latest by default
  • Remove prompts for fst-chart-version since by default it should fetch the latest.
  • Remove dependency on local charts directory during e2e (so that it emulates how user would experience running it)
    • I know this will cause trouble if we need chart updates for a new feature, but we should rely on a release of the chart before we release a new feature in solo

Related Issues

@leninmehedy
Copy link
Member Author

leninmehedy commented Feb 25, 2024

@jeromy-cannon We need to make a patch release with this if this looks good to you.

@leninmehedy leninmehedy requested a review from a team as a code owner February 25, 2024 23:48
Copy link
Contributor

github-actions bot commented Feb 25, 2024

Unit Test Results

 1 files  ±0  13 suites  ±0   21s ⏱️ -1s
83 tests ±0  83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e21f91. ± Comparison against base commit 6df8928.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

E2E Test Results

734 tests  +2   734 ✅ +2   14m 27s ⏱️ + 2m 19s
  6 suites +1     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5e21f91. ± Comparison against base commit 6df8928.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
K8 should be able to get two persistent volume claims ‑ K8 should be able to get two persistent volume claims
ChartManager should be able to check if a chart is installed ‑ ChartManager should be able to check if a chart is installed
ChartManager should be able to list installed charts ‑ ChartManager should be able to list installed charts
K8 should be able to list persistent volume claims ‑ K8 should be able to list persistent volume claims

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.72%. Comparing base (6df8928) to head (5e21f91).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   63.45%   63.72%   +0.27%     
==========================================
  Files          27       27              
  Lines        2553     2553              
  Branches      419      371      -48     
==========================================
+ Hits         1620     1627       +7     
+ Misses        933      926       -7     
Files Coverage Δ
src/commands/cluster.mjs 0.00% <ø> (ø)
src/commands/flags.mjs 93.87% <ø> (ø)
src/commands/init.mjs 75.47% <ø> (ø)
src/commands/network.mjs 0.00% <ø> (ø)
src/commands/node.mjs 54.31% <100.00%> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

@leninmehedy leninmehedy force-pushed the 00066-unable-to-run-solo-cluster-setup branch 3 times, most recently from 7081196 to 3af16ad Compare February 27, 2024 08:42
@leninmehedy leninmehedy force-pushed the 00066-unable-to-run-solo-cluster-setup branch from 3af16ad to 5e21f91 Compare February 27, 2024 09:16
@jeromy-cannon jeromy-cannon merged commit 2e19906 into main Feb 27, 2024
16 checks passed
@jeromy-cannon jeromy-cannon deleted the 00066-unable-to-run-solo-cluster-setup branch February 27, 2024 09:53
swirlds-automation added a commit that referenced this pull request Feb 27, 2024
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))
jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))

Signed-off-by: Jeromy Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run solo cluster setup
3 participants