Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding some type check #217

Merged
merged 13 commits into from
Apr 12, 2024

Merge commit '07f5fe49fac6bc3f2477b1baf99c3d61fa0ed920' into 00045-D-…

a81d56c
Select commit
Loading
Failed to load commit list.
Merged

feat: adding some type check #217

Merge commit '07f5fe49fac6bc3f2477b1baf99c3d61fa0ed920' into 00045-D-…
a81d56c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 12, 2024 in 0s

77.57% (-0.29%) compared to 07f5fe4

View this Pull Request on Codecov

77.57% (-0.29%) compared to 07f5fe4

Details

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 77.57%. Comparing base (07f5fe4) to head (a81d56c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   77.86%   77.57%   -0.29%     
==========================================
  Files          33       33              
  Lines        3560     3586      +26     
  Branches      579      595      +16     
==========================================
+ Hits         2772     2782      +10     
- Misses        788      804      +16     
Files Coverage Δ
...rc/core/dependency_managers/dependency_manager.mjs 100.00% <100.00%> (ø)
...re/dependency_managers/helm_dependency_manager.mjs 90.47% <100.00%> (+0.15%) ⬆️
...dependency_managers/keytool_dependency_manager.mjs 87.65% <100.00%> (+0.15%) ⬆️
src/core/helm.mjs 91.30% <100.00%> (+0.39%) ⬆️
src/core/keytool.mjs 100.00% <100.00%> (ø)
src/commands/init.mjs 75.43% <50.00%> (-0.93%) ⬇️
src/commands/prompts.mjs 68.14% <50.00%> (-0.28%) ⬇️
src/commands/account.mjs 67.66% <33.33%> (-0.53%) ⬇️
src/commands/cluster.mjs 58.01% <0.00%> (-0.90%) ⬇️
src/commands/mirror_node.mjs 0.00% <0.00%> (ø)
... and 3 more

Impacted file tree graph