feat: add Bytes support for transaction iteration in ConsensusEvent and its ancestors

platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java

@@ -35,6 +35,8 @@
 import com.hedera.hapi.node.base.SemanticVersion;
 import com.hedera.hapi.node.state.roster.Roster;
 import com.hedera.hapi.node.state.roster.RosterEntry;
+import com.hedera.hapi.platform.event.EventTransaction;
+import com.hedera.pbj.runtime.io.buffer.Bytes;
 import com.swirlds.common.constructable.ConstructableIgnored;
 import com.swirlds.common.io.SelfSerializable;
 import com.swirlds.common.io.streams.SerializableDataInputStream;
@@ -284,15 +286,37 @@
      * @param transaction the transaction to apply
      */
     private void handleTransaction(final ConsensusTransaction transaction) {
-        if (transaction.isSystem()) {
-            return;
+        int delta;
+
+        if (!transaction.getTransaction().equals(EventTransaction.DEFAULT)) {
+            if (transaction.isSystem()) {
+                return;
+            }
+
+            delta = ByteUtils.byteArrayToInt(
+                    transaction.getApplicationTransaction().toByteArray(), 0);
+
+        } else {
+            if (isSystemTransaction(transaction.getTransactionsBytes())) {
+                return;
+            }
+
+            delta = ByteUtils.byteArrayToInt(transaction.getTransactionsBytes().toByteArray(), 0);
         }
-        final int delta =
-                ByteUtils.byteArrayToInt(transaction.getApplicationTransaction().toByteArray(), 0);
+
         runningSum += delta;
         setChild(RUNNING_SUM_INDEX, new StringLeaf(Long.toString(runningSum)));
     }
 
+    private boolean isSystemTransaction(final Bytes transactionBytes) {
+        if (transactionBytes == null || transactionBytes.length() == 0) {
+            return false;
+        }
+
+        final var transaction = transactionBytes.toByteArray();
+        return transaction[0] != 0;
+    }
+
     /**
      * Iterate over a list of planned incidents, and return the first one that should be triggered. If no incident from
      * the list should be triggered, return null

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/events/EventMetadata.java

@@ -64,6 +64,7 @@ public class EventMetadata extends AbstractHashable {
      * list of transactions
      */
     private final List<TransactionWrapper> transactions;
+
     /**
      * The event descriptor for this event. Is not itself hashed.
      */

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/transaction/Transaction.java

@@ -36,14 +36,23 @@ public sealed interface Transaction permits ConsensusTransaction {
      * @return the transaction
      */
     @NonNull
+    @Deprecated
     EventTransaction getTransaction();
 
+    /**
+     * Returns the transaction bytes as a PBJ record
+     * @return the transaction
+     */
+    @NonNull
+    Bytes getTransactionsBytes();
+
     /**
      * A convenience method for retrieving the application transaction {@link Bytes} object. Before calling this method,
      * ensure that the transaction is not a system transaction by calling {@link #isSystem()}.
      *
      * @return the application transaction Bytes or {@code Bytes.EMPTY} if the transaction is a system transaction
      */
+    @Deprecated
     default @NonNull Bytes getApplicationTransaction() {
         return !isSystem() ? getTransaction().transaction().as() : Bytes.EMPTY;
     }
@@ -61,6 +70,7 @@ public sealed interface Transaction permits ConsensusTransaction {
      * @return {@code true} if this is a system transaction; otherwise {@code false} if this is an application
      * 		transaction
      */
+    @Deprecated
     default boolean isSystem() {
         return TransactionUtils.isSystemTransaction(getTransaction());
     }

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/transaction/TransactionWrapper.java

@@ -39,6 +39,8 @@
     private Object metadata;
     /** The protobuf data stored */
     private final EventTransaction payload;
+    /** The protobuf transaction data stored as bytes */
+    private final Bytes payloadBytes;
     /** The hash of the transaction */
     private Bytes hash;
 
@@ -52,6 +54,7 @@
     public TransactionWrapper(@NonNull final OneOf<TransactionOneOfType> transaction) {
         Objects.requireNonNull(transaction, "transaction should not be null");
         this.payload = new EventTransaction(transaction);
+        this.payloadBytes = Bytes.EMPTY;
     }
 
     /**
@@ -63,6 +66,19 @@
      */
     public TransactionWrapper(@NonNull final EventTransaction transaction) {
         this.payload = Objects.requireNonNull(transaction, "transaction should not be null");
+        this.payloadBytes = Bytes.EMPTY;
+    }
+
+    /**
+     * Constructs a new transaction wrapper
+     *
+     * @param payloadBytes the serialized bytes of the transaction
+     *
+     * @throws NullPointerException if payloadBytes is null
+     */
+    public TransactionWrapper(@NonNull final Bytes payloadBytes) {
+        this.payload = EventTransaction.DEFAULT;
+        this.payloadBytes = Objects.requireNonNull(payloadBytes, "payloadBytes should not be null");
     }
 
     /**
@@ -117,6 +133,20 @@
         return payload;
     }
 
+    @Override
+    @NonNull
+    public Bytes getTransactionsBytes() {
+        if (payloadBytes != null && payloadBytes.length() > 0) {
+            return payloadBytes;
+        }
+
+        if (payload != null && payload.applicationTransaction() != null) {
+            return payload.applicationTransaction();
+        }
+
+        return Bytes.EMPTY;
+    }
+
     /**
      * Get the serialized size of the transaction. This method returns the same value as
      * {@code SwirldsTransaction.getSerializedLength()} and {@code StateSignatureTransaction.getSerializedLength()}.