-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Bytes support for transaction iteration in ConsensusEvent and its ancestors #16844
Conversation
…nd its ancestors Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…epresentation Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16844 +/- ##
============================================
+ Coverage 67.24% 67.29% +0.04%
- Complexity 21991 22008 +17
============================================
Files 2583 2583
Lines 96307 96334 +27
Branches 10054 10056 +2
============================================
+ Hits 64763 64828 +65
+ Misses 27839 27795 -44
- Partials 3705 3711 +6
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/system/events/ConsensusEvent.java
Outdated
Show resolved
Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/system/events/ConsensusEvent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/events/EventMetadata.java
Outdated
Show resolved
Hide resolved
...-platform-core/src/main/java/com/swirlds/platform/system/transaction/TransactionWrapper.java
Outdated
Show resolved
Hide resolved
...atform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
...atform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
Outdated
Show resolved
Hide resolved
...atform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…to 16840-enhance-ConsensusEvent
ee0819c
...atform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
Outdated
Show resolved
Hide resolved
…itself Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…usEvent # Conflicts: # platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolMain.java # platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
...atform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming the ISS Testing Tool nightly tests pass.
Description:
This PR enhances partially ISSTestingTool to work with the incoming transaction representation of Bytes only. Additional filtering and changes should be added when SwirldState API is adapted to handle the new transaction type.
To do so, ConsensusEvent was adapted to return such bytes, since ISSTestingTool and most of the platform testing apps use this interface when handling rounds/transactions.
Additionally, some of the methods connected with the current EventTransaction protobuf wrapper and checks for system transactions are marked as Deprecated, so that they are adapted for the incoming changes of using only Bytes for transactions.
Related issue(s):
Fixes #16840
Notes for reviewer:
The current logic for ISSTestingTool is working as expected.
The new transaction format with Bytes is not tested, since protobuf changes are not adapted and the SwirldState API changes including registering callback for getting back system transactions is not done yet.
Checklist