build: update test-only dependency - Jackson #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackson is a transitive dependency of 'json-snapshot'. In order to use Jackson as Java Module, we update it to the latest version instead of patching it. Unfortunately, 'json-snapshot' has not been updated in years and the way we used it is not compatible with the latest Jackson version. By adjusting the test setup as described here, we make it work: json-snapshot/json-snapshot.github.io#27 (comment) Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
force-pushed
the
update-jackson
branch
from
88c86b2 to
a26d978
Compare
3 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Jackson is a transitive dependency of 'json-snapshot'. In order to use Jackson as Java Module, we update it to the latest version instead of patching it.
Unfortunately, 'json-snapshot' has not been updated in years and the way we used it is not compatible with the latest Jackson version.
By adjusting the test setup as described here, we make it work: json-snapshot/json-snapshot.github.io#27 (comment)
Related issue(s):
This is (also) done to allow us to use the same Jackson versions across multiple hedera repositories in the context of hashgraph/hedera-services#14255.
Notes for reviewer:
Checklist