-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the documentation on how to get started with the Java SDK #1621
Conversation
) Signed-off-by: Nikita Lebedev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My questions for review
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
…against the local network (#1595, #1622) Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1621 +/- ##
=============================================
+ Coverage 82.20% 82.23% +0.02%
- Complexity 3587 3589 +2
=============================================
Files 186 186
Lines 11697 11697
Branches 1148 1148
=============================================
+ Hits 9616 9619 +3
+ Misses 1603 1602 -1
+ Partials 478 476 -2 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # README.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
============================================
+ Coverage 82.20% 82.23% +0.03%
- Complexity 3588 3589 +1
============================================
Files 186 186
Lines 11697 11697
Branches 1150 1148 -2
============================================
+ Hits 9615 9619 +4
+ Misses 1604 1602 -2
+ Partials 478 476 -2 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
# Conflicts: # README.md
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Improve the documentation on how to get started with the Java SDK:
This PR also fixes the documentation:
Related issue(s):
Fixes #1595 #1622