build: Kotlin DSL / Convention Plugins / Java Modules #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
changed the title
jjohannes
force-pushed
the
gradle-updates
branch
10 times, most recently
from
06771f8 to
c32db9d
Compare
jjohannes
changed the title
jjohannes
commented
Feb 22, 2024
examples/src/main/java/com/hedera/hashgraph/sdk/examples/ContractHelper.java
Show resolved
Hide resolved
jjohannes
commented
Feb 22, 2024
sdk/src/test/java/com/hedera/hashgraph/sdk/AccountAllowanceDeleteTransactionTest.java
Show resolved
Hide resolved
jjohannes
force-pushed
the
gradle-updates
branch
from
ebd45ae to
9c91763
Compare
jjohannes
requested review from
agadzhalov,
thenswan and
SimiHunjan
as code owners
|
@jjohannes Please rebase this PR when you get a chance. The team is ready to review and merge. |
jjohannes
force-pushed
the
gradle-updates
branch
2 times, most recently
from
d659795 to
d7bb746
Compare
|
@nathanklick rebased and ready for review |
|
|
I merged PR related to the docs update (recommend to check it out), and we have a doc on creating a fat/uber JAR based on the user's request. Would like to ask if is it possible for jar creation to be done as a convention plugin (like in hedera-services)? |
|
Proposing change |
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
This allows using it to run the examples against published versions of the SDK. Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
As soon as you declare capabilities, the default capability is no longer added automatically. This can lead to really weird variant matching issues. Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
|
agadzhalov
approved these changes
Jul 9, 2024
0xivanov
approved these changes
Jul 9, 2024
rbarkerSL
reviewed
Jul 9, 2024
rbarkerSL
approved these changes
Jul 9, 2024
This was referenced Jul 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR does the full package of Gradle + Java Module updates similar to what we did in hedera-services:
io.grpc:*dependencies to 1.64.0 (to be Java Module compatible)module-info.javafiles added tosdk/main,sdk/integrationTestandexamplesmodule-info.javaand scope is defined according tocheckAllModuleInfosdk-dependency-versions/build.gradle.ktssdk-fullproject that has a separatemodule-info(exchangingrequires grpc.protobuf.liteforrequires grpc.protobuf) but otherwise re-uses sources and proto buffs from thesdk/mainsources folder.sdkandsdk-fullare now both published by the Gradle build in the one publishing runSide-effects:
io.grpc:grpc-netty-shadedin client project is automatically aligned with thegrpc-apiversion we useManual Testing (for things not covered by the automatic tests):
Follow ups: