feat(tokenDeleteTransaction): Implement JSON-RPC endpoint for TokenDeleteTransaction

src/sdk/main/include/CustomFractionalFee.h

@@ -87,7 +87,6 @@ class CustomFractionalFee : public CustomFeeBase<CustomFractionalFee>
  * @param denominator The desired denominator of the fractional amount of the transferred units to assess as a part of
  * this CustomFractionalFee.
  * @return A reference to this CustomFractionalFee object, with the newly-set denominator.
- * @throws std::invalid_argument If the input denominator is 0.
  */
  CustomFractionalFee& setDenominator(const int64_t& denominator);
 

src/sdk/main/include/CustomRoyaltyFee.h

@@ -87,7 +87,6 @@ class CustomRoyaltyFee : public CustomFeeBase<CustomRoyaltyFee>
  * @param denominator The desired denominator of the fractional amount of the transferred units to assess as a part of
  * this CustomRoyaltyFee.
  * @return A reference to this CustomRoyaltyFee object, with the newly-set denominator.
- * @throws std::invalid_argument If the input denominator is 0.
  */
  CustomRoyaltyFee& setDenominator(const int64_t& denominator);
 

src/sdk/main/include/FeeAssessmentMethod.h

@@ -20,6 +20,7 @@
 #ifndef HEDERA_SDK_CPP_FEE_ASSESSMENT_METHOD_H_
 #define HEDERA_SDK_CPP_FEE_ASSESSMENT_METHOD_H_
 
+#include <string>
 #include <unordered_map>
 
 namespace Hedera
@@ -46,11 +47,19 @@ enum class FeeAssessmentMethod
 /**
  * Map of FeeAssessmentMethod to its corresponding string.
  */
-const std::unordered_map<FeeAssessmentMethod, const char*> gFeeAssessmentMethodToString = {
+const std::unordered_map<FeeAssessmentMethod, std::string> gFeeAssessmentMethodToString = {
  {FeeAssessmentMethod::INCLUSIVE, "INCLUSIVE"},
  { FeeAssessmentMethod::EXCLUSIVE, "EXCLUSIVE"}
 };
 
+/**
+ * Map of FeeAssessmentMethod string representation to its corresponding enum value.
+ */
+[[maybe_unused]] const std::unordered_map<std::string, FeeAssessmentMethod> gStringToFeeAssessmentMethod = {
+ {"INCLUSIVE", FeeAssessmentMethod::INCLUSIVE},
+ { "EXCLUSIVE", FeeAssessmentMethod::EXCLUSIVE}
+};
+
 } // namespace Hedera
 
 #endif // HEDERA_SDK_CPP_FEE_ASSESSMENT_METHOD_H_

src/sdk/main/src/CustomFractionalFee.cc

@@ -87,11 +87,6 @@ CustomFractionalFee& CustomFractionalFee::setNumerator(const int64_t& numerator)
 //-----
 CustomFractionalFee& CustomFractionalFee::setDenominator(const int64_t& denominator)
 {
- if (denominator == 0LL)
- {
- throw std::invalid_argument("Denominator cannot be 0");
- }
-
  mDenominator = denominator;
  return *this;
 }

src/sdk/main/src/CustomRoyaltyFee.cc

@@ -91,11 +91,6 @@ CustomRoyaltyFee& CustomRoyaltyFee::setNumerator(const int64_t& numerator)
 //-----
 CustomRoyaltyFee& CustomRoyaltyFee::setDenominator(const int64_t& denominator)
 {
- if (denominator == 0LL)
- {
- throw std::invalid_argument("Denominator cannot be 0");
- }
-
  mDenominator = denominator;
  return *this;
 }

src/sdk/tests/unit/CustomFractionalFeeUnitTests.cc

@@ -175,16 +175,6 @@ TEST_F(CustomFractionalFeeUnitTests, GetSetDenominator)
  EXPECT_EQ(customFractionalFee.getDenominator(), getTestDenominator());
 }
 
-//-----
-TEST_F(CustomFractionalFeeUnitTests, CannotSetDenominatorToZero)
-{
- // Given
- CustomFractionalFee customFractionalFee;
-
- // When / Then
- EXPECT_THROW(customFractionalFee.setDenominator(0LL), std::invalid_argument);
-}
-
 //-----
 TEST_F(CustomFractionalFeeUnitTests, GetSetMinimumAmount)
 {

src/sdk/tests/unit/CustomRoyaltyFeeUnitTests.cc

@@ -157,16 +157,6 @@ TEST_F(CustomRoyaltyFeeUnitTests, GetSetDenominator)
  EXPECT_EQ(customRoyaltyFee.getDenominator(), getTestDenominator());
 }
 
-//-----
-TEST_F(CustomRoyaltyFeeUnitTests, CannotSetDenominatorToZero)
-{
- // Given
- CustomRoyaltyFee customRoyaltyFee;
-
- // When / Then
- EXPECT_THROW(customRoyaltyFee.setDenominator(0LL), std::invalid_argument);
-}
-
 //-----
 TEST_F(CustomRoyaltyFeeUnitTests, GetSetFallbackFee)
 {

src/sdk/tests/unit/FeeAssessmentMethodUnitTests.cc

@@ -33,6 +33,6 @@ TEST_F(FeeAssessmentMethodUnitTests, FeeAssessmentMethodToString)
  // Given / When / Then
  ASSERT_TRUE(gFeeAssessmentMethodToString.find(FeeAssessmentMethod::INCLUSIVE) != gFeeAssessmentMethodToString.end());
  ASSERT_TRUE(gFeeAssessmentMethodToString.find(FeeAssessmentMethod::EXCLUSIVE) != gFeeAssessmentMethodToString.end());
- EXPECT_STRCASEEQ(gFeeAssessmentMethodToString.at(FeeAssessmentMethod::INCLUSIVE), "INCLUSIVE");
- EXPECT_STRCASEEQ(gFeeAssessmentMethodToString.at(FeeAssessmentMethod::EXCLUSIVE), "EXCLUSIVE");
+ EXPECT_EQ(gFeeAssessmentMethodToString.at(FeeAssessmentMethod::INCLUSIVE), "INCLUSIVE");
+ EXPECT_EQ(gFeeAssessmentMethodToString.at(FeeAssessmentMethod::EXCLUSIVE), "EXCLUSIVE");
 }

src/tck/include/CommonTransactionParams.h

@@ -37,7 +37,7 @@
 namespace Hedera::TCK
 {
 /**
- * Struct the contains the common parameters of a Transaction.
+ * Struct that contains the common parameters of a Transaction.
  */
 struct CommonTransactionParams
 {