Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokenDeleteTransaction): Implement JSON-RPC endpoint for TokenDeleteTransaction #790

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rwalworth
Copy link
Contributor

@rwalworth rwalworth commented Oct 9, 2024

Description:
This PR implements the JSON-RPC for TokenDeleteTransaction (deleteToken).

Related issue(s):

This contains work in #793, so that should be reviewed first.

Fixes #789

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…dated/fixed processing of fractional fees

Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…etransaction' into 00789-tck-c++-implement-json-rpc-methods-for-tokendeletetransaction

Signed-off-by: Rob Walworth <[email protected]>
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Oct 9, 2024
@rwalworth rwalworth self-assigned this Oct 9, 2024
@rwalworth rwalworth requested review from a team as code owners October 9, 2024 15:15
@rwalworth rwalworth linked an issue Oct 9, 2024 that may be closed by this pull request
src/tck/src/SdkClient.cc Show resolved Hide resolved
src/tck/src/main.cc Show resolved Hide resolved
Signed-off-by: Rob Walworth <[email protected]>
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-C++: Implement JSON-RPC methods for TokenDeleteTransaction
2 participants