Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement agreed upon changes based on discussion (#266) #336

addressing pr comment

93c2c06
Select commit
Loading
Failed to load commit list.
Merged

refactor: implement agreed upon changes based on discussion (#266) #336

addressing pr comment
93c2c06
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

94.05% (target 80.00%)

View this Pull Request on Codecov

94.05% (target 80.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (401b645) to head (93c2c06).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #336      +/-   ##
============================================
+ Coverage     93.98%   94.05%   +0.07%     
- Complexity      288      300      +12     
============================================
  Files            66       68       +2     
  Lines          1163     1177      +14     
  Branches         83       82       -1     
============================================
+ Hits           1093     1107      +14     
  Misses           57       57              
  Partials         13       13              
Files with missing lines Coverage Δ
...a/com/hedera/block/common/utils/FileUtilities.java 100.00% <100.00%> (ø)
...a/com/hedera/block/common/utils/MathUtilities.java 100.00% <100.00%> (ø)
...a/com/hedera/block/common/utils/Preconditions.java 100.00% <100.00%> (ø)
...com/hedera/block/common/utils/StringUtilities.java 100.00% <100.00%> (ø)
...m/hedera/block/server/mediator/MediatorConfig.java 100.00% <100.00%> (ø)
...m/hedera/block/server/notifier/NotifierConfig.java 100.00% <100.00%> (ø)