-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement agreed upon changes based on discussion (#266) #336
refactor: implement agreed upon changes based on discussion (#266) #336
Conversation
…ethod Signed-off-by: Atanas Atanasov <[email protected]>
…eger check Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Please remove all the exclamation points from the exception message strings.
server/src/main/java/com/hedera/block/server/notifier/NotifierConfig.java
Outdated
Show resolved
Hide resolved
server/src/test/java/com/hedera/block/server/mediator/MediatorConfigTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
93c2c06
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
============================================
+ Coverage 93.98% 94.05% +0.07%
- Complexity 288 300 +12
============================================
Files 66 68 +2
Lines 1163 1177 +14
Branches 83 82 -1
============================================
+ Hits 1093 1107 +14
Misses 57 57
Partials 13 13
|
Description:
Implement agreed upon changes from discussion #266
Related issue(s):
Fixes #305
Checklist
MathUtilities
isPowerOfTwo(int)
boolean check insideMathUtilities
Preconditions
requirePowerOfTwo(int)
strict precondition insidePreconditions
isBlank(String)
boolean check insideStringUtilities
StringUtilities#requireNotBlank(String)
toPreconditions
MathUtilities
into the respective places