Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement agreed upon changes based on discussion (#266) #305

Closed
ata-nas opened this issue Oct 24, 2024 · 2 comments · Fixed by #336
Closed

refactor: implement agreed upon changes based on discussion (#266) #305

ata-nas opened this issue Oct 24, 2024 · 2 comments · Fixed by #336
Assignees
Labels
Common Issue/PR related to Common module Improvement Code changes driven by non business requirements
Milestone

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Oct 24, 2024

Description

Based on discussion #266, implement the changes agreed upon there as seen in the task list below.

Tasklist

  • create new class MathUtilities
  • implement proposed change to create isPowerOfTwo(int) boolean check inside MathUtilities
  • create new class Preconditions
  • implement proposed change to create requirePowerOfTwo(int) strict precondition inside Preconditions
  • implement proposed change to create isBlank(String) boolean check inside StringUtilities
  • implement proposed change to move StringUtilities#requireNotBlank(String) to Preconditions
@ata-nas ata-nas added Improvement Code changes driven by non business requirements Common Issue/PR related to Common module labels Oct 24, 2024
@ata-nas ata-nas added this to the 0.2.0 milestone Oct 24, 2024
@AlfredoG87
Copy link
Contributor

@ata-nas could you confirm if this is still pending or is already completed?

@ata-nas
Copy link
Contributor Author

ata-nas commented Nov 11, 2024

@ata-nas could you confirm if this is still pending or is already completed?

@AlfredoG87 this is pending, I will be including it in one of my PRs soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Issue/PR related to Common module Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants