-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace grpc.io
with PBJ Helidon Plugin
#237
Conversation
5f5bfea
to
6a8a5be
Compare
d217bde
to
f752b2b
Compare
f752b2b
to
2e67746
Compare
815b764
to
b3eca7c
Compare
grpc.io
with PBJ Helidon Plugin
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
002c440
to
c82d6b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, this is great job!! 💯
just leaved a few nits.
server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockStreamService.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockStreamServiceProxy.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Peterson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval applies to codecov.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Changes:
grpc.io
toPBJ Helidon Plugin
configurationhelidon.properties
producer.sh
andconsumer.sh
to work withrepeated
blockitems