Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace grpc.io with PBJ Helidon Plugin #237

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Oct 8, 2024

PR Changes:

  • Changed from grpc.io to PBJ Helidon Plugin configuration
  • Removed Translator code in the server and simulator
  • The server now uses PBJ types exclusively
  • The simulator uses protoc types exclusively
  • Added NoOp config-based implementations to assist with troubleshooting
  • Added new ring buffer metrics and dashboard
  • Reduced the default ring buffer sizes based on testing observations
  • Added helidon configurability via helidon.properties
  • Fixed producer.sh and consumer.sh to work with repeated blockitems
  • Augmented simulator BlockAsFileLargeDataSets with range config
  • Fixes Flaky unit test #311
  • Fixed tests
  • Fixes Use custom gRPC implementation with Helidon #180

@mattp-swirldslabs mattp-swirldslabs self-assigned this Oct 8, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00180-import-local-pbj-jar branch 2 times, most recently from 5f5bfea to 6a8a5be Compare October 23, 2024 20:52
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00180-import-local-pbj-jar branch from d217bde to f752b2b Compare October 30, 2024 21:28
@mattp-swirldslabs mattp-swirldslabs changed the title 00180 import local pbj jar feat: 00180 import local pbj jar Oct 30, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00180-import-local-pbj-jar branch from f752b2b to 2e67746 Compare November 7, 2024 20:48
@mattp-swirldslabs mattp-swirldslabs added the dependencies Pull requests that update a dependency file label Nov 7, 2024
@mattp-swirldslabs mattp-swirldslabs modified the milestone: 0.2.0 Nov 7, 2024
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review November 7, 2024 21:45
@mattp-swirldslabs mattp-swirldslabs requested review from a team as code owners November 7, 2024 21:45
@mattp-swirldslabs mattp-swirldslabs added this to the 0.2.0 milestone Nov 7, 2024
jeromy-cannon
jeromy-cannon previously approved these changes Nov 8, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00180-import-local-pbj-jar branch 2 times, most recently from 815b764 to b3eca7c Compare November 8, 2024 12:53
@mattp-swirldslabs mattp-swirldslabs changed the title feat: 00180 import local pbj jar feat: Replace grpc.io with PBJ Helidon Plugin Nov 8, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00180-import-local-pbj-jar branch from 002c440 to c82d6b3 Compare November 8, 2024 19:57
AlfredoG87
AlfredoG87 previously approved these changes Nov 8, 2024
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, this is great job!! 💯

just leaved a few nits.

Signed-off-by: Matt Peterson <[email protected]>
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval applies to codecov.yml

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs merged commit 98b2eeb into main Nov 8, 2024
13 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00180-import-local-pbj-jar branch November 8, 2024 20:55
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 82.39437% with 50 lines in your changes missing coverage. Please review.

Project coverage is 93.98%. Comparing base (76811f0) to head (52d112a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/block/server/pbj/PbjBlockStreamServiceProxy.java 56.36% 23 Missing and 1 partial ⚠️
...ock/server/producer/ProducerBlockItemObserver.java 65.21% 8 Missing ⚠️
...a/block/server/pbj/PbjBlockAccessServiceProxy.java 89.79% 5 Missing ⚠️
.../simulator/generator/BlockAsFileLargeDataSets.java 83.33% 2 Missing and 1 partial ⚠️
...block/server/mediator/MediatorInjectionModule.java 75.00% 1 Missing and 1 partial ⚠️
...server/persistence/PersistenceInjectionModule.java 66.66% 1 Missing and 1 partial ⚠️
...ck/simulator/config/data/BlockGeneratorConfig.java 66.66% 1 Missing and 1 partial ⚠️
...ck/simulator/grpc/PublishStreamGrpcClientImpl.java 92.59% 1 Missing and 1 partial ⚠️
...era/block/server/config/ConfigInjectionModule.java 0.00% 1 Missing ⚠️
...era/block/simulator/mode/PublisherModeHandler.java 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #237      +/-   ##
============================================
- Coverage     98.48%   93.98%   -4.51%     
+ Complexity      294      288       -6     
============================================
  Files            63       66       +3     
  Lines          1124     1163      +39     
  Branches         79       83       +4     
============================================
- Hits           1107     1093      -14     
- Misses           11       57      +46     
- Partials          6       13       +7     
Files with missing lines Coverage Δ
...ain/java/com/hedera/block/server/BlockNodeApp.java 100.00% <100.00%> (ø)
.../block/server/config/BlockNodeConfigExtension.java 100.00% <ø> (ø)
...erver/consumer/ConsumerStreamResponseObserver.java 98.11% <100.00%> (-1.89%) ⬇️
.../block/server/mediator/LiveStreamMediatorImpl.java 100.00% <100.00%> (ø)
...m/hedera/block/server/mediator/MediatorConfig.java 100.00% <100.00%> (ø)
...era/block/server/metrics/BlockNodeMetricTypes.java 100.00% <100.00%> (ø)
...m/hedera/block/server/notifier/NotifierConfig.java 100.00% <ø> (ø)
...com/hedera/block/server/notifier/NotifierImpl.java 100.00% <100.00%> (ø)
...hedera/block/server/pbj/PbjBlockAccessService.java 100.00% <100.00%> (ø)
...hedera/block/server/pbj/PbjBlockStreamService.java 100.00% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unit test Use custom gRPC implementation with Helidon
4 participants