fix: PR review fixes

Signed-off-by: Matt Peterson <[email protected]>
hashgraph · Nov 8, 2024 · 52d112a · 52d112a
1 parent c82d6b3
commit 52d112a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessService.java b/server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessService.java
@@ -16,6 +16,7 @@
 
 package com.hedera.block.server.pbj;
 
+import static com.hedera.block.server.Constants.FULL_SERVICE_NAME_BLOCK_ACCESS;
 import static com.hedera.block.server.Constants.SERVICE_NAME_BLOCK_ACCESS;
 
 import com.hedera.pbj.runtime.grpc.ServiceInterface;
@@ -57,7 +58,7 @@ default String serviceName() {
      */
     @NonNull
     default String fullName() {
-        return "com.hedera.hapi.block." + SERVICE_NAME_BLOCK_ACCESS;
+        return FULL_SERVICE_NAME_BLOCK_ACCESS;
     }
 
     /**

diff --git a/server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java b/server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java
@@ -145,7 +145,7 @@ SingleBlockResponse singleBlock(SingleBlockRequest singleBlockRequest) {
     @NonNull
     private SingleBlockRequest parseSingleBlockRequest(
             @NonNull final Bytes message, @NonNull final RequestOptions options) throws ParseException {
-        // Copying bytes to avoid using references passed from Helidon
+        // TODO: Copying bytes to avoid using references passed from Helidon. Investigate if this is necessary.
         return SingleBlockRequest.PROTOBUF.parse(Bytes.wrap(message.toByteArray()));
     }
 

diff --git a/server/src/main/java/com/hedera/block/server/pbj/PbjBlockStreamServiceProxy.java b/server/src/main/java/com/hedera/block/server/pbj/PbjBlockStreamServiceProxy.java
@@ -178,7 +178,7 @@ void subscribeBlockStream(
     @NonNull
     private SubscribeStreamRequest parseSubscribeStreamRequest(
             @NonNull final Bytes message, @NonNull final RequestOptions options) throws ParseException {
-        // Copying bytes to avoid using references passed from Helidon
+        // TODO: Copying bytes to avoid using references passed from Helidon. Investigate if this is necessary.
         return SubscribeStreamRequest.PROTOBUF.parse(Bytes.wrap(message.toByteArray()));
     }
 
@@ -191,7 +191,7 @@ private Bytes createSubscribeStreamResponse(
     @NonNull
     private PublishStreamRequest parsePublishStreamRequest(
             @NonNull final Bytes message, @NonNull final RequestOptions options) throws ParseException {
-        // Copying bytes to avoid using references from Helidon
+        // TODO: Copying bytes to avoid using references passed from Helidon. Investigate if this is necessary.
         return PublishStreamRequest.PROTOBUF.parse(Bytes.wrap(message.toByteArray()));
     }