external disk support enhancements - disable multipath by default (backport #831) #832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor change to disable multipath via kernel arguments when no exteral storage config is present.
This ensures initrd does not load it before switching rootfs and avoids unwanted side effect of /dev/mapper devices for disks being created
Problem:
to enable multipathd on boot disks as part of the external disk support, multipathd has been enabled by default in initrd.
when multipath is not needed, initrd still loads multipathd, which gets shutdown during switching of rootfs
As a result it can cause unintended consequences when non multipath disks get picked up and a /dev/mapper device gets setup and NDM picks up the mapper device
Solution:
Minor change to add default third party kernel argument of
multipath=off
when external disk support is not enabledRelated Issue:
Test plan:
This is an automatic backport of pull request #831 done by [Mergify](https://mergify.com).