Skip to content

Commit

Permalink
minor change to disable multipath via kernel arguments when no extern…
Browse files Browse the repository at this point in the history
…al storage config is present. This ensures initrd does not load it before switching rootfs and avoids unwanted side effect of /dev/mapper devices for disks being created

(cherry picked from commit 21679ef)
  • Loading branch information
ibrokethecloud authored and bk201 committed Sep 13, 2024
1 parent 266a6eb commit 95d9e76
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/console/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ You can see the full installation log by:

ElementalConfigDir = "/tmp/elemental"
ElementalConfigFile = "config.yaml"
multipathOff = "multipath=off"
)

func newProxyClient() http.Client {
Expand Down Expand Up @@ -504,6 +505,9 @@ func doInstall(g *gocui.Gui, hvstConfig *config.HarvesterConfig, webhooks Render
env = append(env, fmt.Sprintf("HARVESTER_DATA_DISK=%s", hvstConfig.DataDisk))
}

if !hvstConfig.OS.ExternalStorage.Enabled {
env = append(env, fmt.Sprintf("HARVESTER_ADDITIONAL_KERNEL_ARGUMENTS=%s", multipathOff))
}
if hvstConfig.OS.AdditionalKernelArguments != "" {
env = append(env, fmt.Sprintf("HARVESTER_ADDITIONAL_KERNEL_ARGUMENTS=%s", hvstConfig.OS.AdditionalKernelArguments))
}
Expand Down

0 comments on commit 95d9e76

Please sign in to comment.