config: make sftp could be configured dynamically

[Vicente-Cheng]

Problem:
Give the way to config sftp dynamically

Solution:
We could set up the harvester.os.sshd.sftp to true.
The harvester-installer would create the related config file by stage AfterInstallChrootCommands

We also need the harvester/os2#78
That would include the customer config that we would like to add.

Related Issue:
harvester/harvester#4480

Test plan:

• Perform an ipxe-example installation with this config

  os:
    sshd:
       sftp: true
  

• Try to access sftp

  sftp [email protected]
  ([email protected]) Password:
  Connected to 192.168.0.30.
  sftp> 
  

[Vicente-Cheng]

Hi @guangbochen, @bk201,

This is an easy way to make config sftp simple.
For this implementation, we only support automatic installation (which means we need to load the harvester config).
We could also implement the related part if we would like to expose this to the interactive installation mode.

What do you think of this implementation?

[bk201]

@ibrokethecloud Please help check the issue and give some feedback. Thanks!

[ibrokethecloud]

the config for AfterInstallChrootCommands is going to be lost post an upgrade.

would it be feasible to make this an addon? and run a daemonset serving sftp? This way we can rollout updates and ensure service is maintained post upgrade?

[Vicente-Cheng]

the config for AfterInstallChrootCommands is going to be lost post an upgrade.

would it be feasible to make this an addon? and run a daemonset serving sftp? This way we can rollout updates and ensure service is maintained post upgrade?

After I checked, the /etc/ssh is the persistent path. Anything we added on it will be saved even we do a system upgrade.
So I think we could simply apply this file.

[ibrokethecloud]

lgtm. thanks.

[Vicente-Cheng]

@Mergifyio backport v1.2

[mergify]

backport v1.2

✅ Backports have been created

• #627 config: make sftp could be configured dynamically (backport #562) has been created for branch v1.2