Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansiable: add sftp config #79

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Vicente-Cheng
Copy link
Contributor

- we support sftp configuration when installation.

make default that could be easier to transmit file

related to harvester/harvester-installer#562

@Vicente-Cheng Vicente-Cheng requested review from bk201 and a team February 29, 2024 03:10
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Thanks @Vicente-Cheng
LGTM!

@Vicente-Cheng
Copy link
Contributor Author

Vicente-Cheng commented Mar 3, 2024

Hi folks, I changed this configuration scope, which can be changed easily.

Please help to recheck it!

Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

    - we support sftp configuration when installation.

    make default that could be easier to transmit file

Signed-off-by: Vicente Cheng <[email protected]>
@albinsun albinsun merged commit 28b99fd into harvester:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants