Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.2] Remove orgId param in grafana link #977

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

w13915984028
Copy link
Member

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes #

With the new PR harvester/harvester-installer#681 to bump rancher-monitoring in Harvester v1.2.2, the embedded Rancher was also bumped to v2.8.2.

The current UI will have such error:
image

image

After remove /?orgId=1 from the link, it works.

 <a data-v-778364ee="" data-v-590b7fec="" href="/k8s/clusters/local/api/v1/namespaces/cattle-monitoring-system/services/http:rancher-monitoring-grafana:80/proxy/?orgId=1" target="_blank" rel="noopener nofollow"> ...

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@w13915984028
Copy link
Member Author

Note:

When rancher-monitoring and embedded Rancher versions are not bumped, the PR #961 is needed for Harvester v1.2.1;

For v1.2.2, due to those versions bumping, the PR 961 is not required.

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit 3443f22 into harvester:release-harvester-v1.2 Apr 2, 2024
5 checks passed
@bk201
Copy link
Member

bk201 commented Apr 2, 2024

@w13915984028 do you know which issue this PR belongs to and if we can move the issue to ready for testing? Thanks.

@w13915984028
Copy link
Member Author

@bk201 The issue is harvester/harvester#5412, this PR is mentioned in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants