Remove Message:exists #39
Merged
+0
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expensive resulting in many queries ERM34902
osnard
requested changes
Jan 11, 2024
|
MediaWiki Sidebar doesn't seem to use SimpleTreeLinkNode.php or SimpleTreeTextNode.php; it uses SimpleCard.php, SimpleCardHeader.php.& SimpleLinklistGroupFromArray.php. Update: Enhanced Sidebar does -> working on solution. |
|
Parse Message key in Enhanced Sidebar |
DvogelHallowelt
approved these changes
Jan 15, 2024
|
Using a modified version of SimpleTreeLinkNode for the book tree-panel is overhead. It is much more easier to modify code like suggested and modify the sidebar implementation in skin |
osnard
approved these changes
Jan 15, 2024
wmfgerrit
pushed a commit
to wikimedia/mediawiki-skins-BlueSpiceDiscovery
that referenced
this pull request
Jan 15, 2024
Allows removal of Message:exists from commonuserinterface component Expensive resulting in many queries hallowelt/mwstake-mediawiki-component-commonuserinterface#39 ERM34902 [REL1_39, REL1_39-4.4.x, master] Change-Id: I1dfebceebdb55b8083fa8463fbbe41278aa3618b
wmfgerrit
pushed a commit
to wikimedia/mediawiki-skins-BlueSpiceDiscovery
that referenced
this pull request
Jan 15, 2024
Allows removal of Message:exists from commonuserinterface component Expensive resulting in many queries hallowelt/mwstake-mediawiki-component-commonuserinterface#39 ERM34902 [REL1_39, REL1_39-4.4.x, master] Change-Id: I1dfebceebdb55b8083fa8463fbbe41278aa3618b
wmfgerrit
pushed a commit
to wikimedia/mediawiki-skins-BlueSpiceDiscovery
that referenced
this pull request
Jan 15, 2024
Allows removal of Message:exists from commonuserinterface component Expensive resulting in many queries hallowelt/mwstake-mediawiki-component-commonuserinterface#39 ERM34902 [REL1_39, REL1_39-4.4.x, master] Change-Id: I1dfebceebdb55b8083fa8463fbbe41278aa3618b
wmfgerrit
pushed a commit
to wikimedia/mediawiki-skins
that referenced
this pull request
Jan 15, 2024
* Update BlueSpiceDiscovery from branch 'master'
to 1ada1f164cbfd32e9b5680b0cf3a2305bad7d67b
- Parse Message key
Allows removal of Message:exists from commonuserinterface component
Expensive resulting in many queries
hallowelt/mwstake-mediawiki-component-commonuserinterface#39
ERM34902
[REL1_39, REL1_39-4.4.x, master]
Change-Id: I1dfebceebdb55b8083fa8463fbbe41278aa3618b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expensive resulting in many queries
ERM34902