Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added KnownIssue category, annotated known issues #365

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added KnownIssue category, annotated known issues #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43879cc
added KnownIssue category, annotated known issues
Dec 6, 2017
27e973a
added withoutKnownIssues profile
Dec 11, 2017
d21ca09
Added smart testing
Jan 22, 2018
26a79d3
Added smart testing
Jan 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@ target
.project
.idea
*.iml
.vscode/
basic/periodic-handler.log

# Smart Testing Exclusions
.smart-testing/

8 changes: 8 additions & 0 deletions .mvn/extensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<extensions>
<extension>
<groupId>org.arquillian.smart.testing</groupId>
<artifactId>maven-lifecycle-extension</artifactId>
<version>0.0.6</version>
</extension>
</extensions>
2 changes: 2 additions & 0 deletions ...t/java/org/jboss/hal/testsuite/test/configuration/datasources/TestConnectionTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.apache.commons.lang3.RandomStringUtils;
import org.jboss.arquillian.container.test.api.RunAsClient;
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.hal.testsuite.category.KnownIssue;
import org.jboss.hal.testsuite.category.Shared;
import org.jboss.hal.testsuite.creaper.ManagementClientProvider;
import org.jboss.hal.testsuite.creaper.ResourceVerifier;
Expand Down Expand Up @@ -171,6 +172,7 @@ public void invalidXADatasource() {
}

@Test
@Category(KnownIssue.class)
public void testValidXAConnectionInWizardAndCancel() throws Exception {
datasourcesPage.invokeAddXADatasource();

Expand Down
2 changes: 2 additions & 0 deletions .../java/org/jboss/hal/testsuite/test/configuration/elytron/other/ElytronPolicyTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.dmr.ModelNode;
import org.jboss.hal.testsuite.category.Elytron;
import org.jboss.hal.testsuite.category.KnownIssue;
import org.jboss.hal.testsuite.creaper.ResourceVerifier;
import org.jboss.hal.testsuite.dmr.ModelNodeGenerator;
import org.jboss.hal.testsuite.fragment.ConfigFragment;
Expand Down Expand Up @@ -291,6 +292,7 @@ public void testEditJACCPolicy() throws Exception {
}

@Test
@Category(KnownIssue.class)
public void testEditJACCPolicySingleAttribute() throws Exception {
final String jaccPolicyName = randomAlphabetic(7);
final String defaultModuleName = policyModuleName;
Expand Down
2 changes: 2 additions & 0 deletions ...est/java/org/jboss/hal/testsuite/test/runtime/deployments/ManagedDeploymentsTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.jboss.arquillian.drone.api.annotation.Drone;
import org.jboss.arquillian.graphene.page.Page;
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.hal.testsuite.category.KnownIssue;
import org.jboss.hal.testsuite.category.Standalone;
import org.jboss.hal.testsuite.creaper.ManagementClientProvider;
import org.jboss.hal.testsuite.creaper.command.DeployCommand;
Expand Down Expand Up @@ -391,6 +392,7 @@ public void medExplodedDeploymentFlagFalseInViewInfoSuccessExpected() {
}

@Test
@Category(KnownIssue.class)
public void medExplodedDeploymentFlagTrueInViewInfoSuccessExpected() {
page.navigateToDeploymentAndInvokeView(DEPLOYMENT_MANAGED_ENABLED_8);

Expand Down
2 changes: 2 additions & 0 deletions basic/src/test/java/org/jboss/hal/testsuite/test/runtime/messaging/XaJmsMetricsTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.jboss.arquillian.graphene.page.Page;
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.dmr.ModelNode;
import org.jboss.hal.testsuite.category.KnownIssue;
import org.jboss.hal.testsuite.category.Shared;
import org.jboss.hal.testsuite.creaper.ManagementClientProvider;
import org.jboss.hal.testsuite.creaper.ResourceVerifier;
Expand Down Expand Up @@ -121,6 +122,7 @@ public static void afterClass() throws Exception {
* the connection factory and verify against management model that displayed statistics have changed correctly.
*/
@Test
@Category(KnownIssue.class)
public void jmsXaPoolStatisticsTest() throws Exception {
generateStats();
page.navigateToDefaultProviderStats().switchToPooledConnectionFactory()
Expand Down
4 changes: 4 additions & 0 deletions common/src/main/java/org/jboss/hal/testsuite/category/KnownIssue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package org.jboss.hal.testsuite.category;

public interface KnownIssue {
}
18 changes: 13 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
<artifactId>selenium-bom</artifactId>
<version>2.39.0</version>
<type>pom</type>
<scope>import</scope>
<scope>provided</scope>
</dependency>

<dependency>
Expand Down Expand Up @@ -378,6 +378,16 @@
</properties>
</profile>

<profile>
<id>withoutKnownIssues</id>
<properties>
<test.excluded.category>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be conflict of test.excluded.category property between noSecurity and withoutKnownIssues profiles. If you use them both it would be IMO overwritten.

org.jboss.hal.testsuite.category.KnownIssue
</test.excluded.category>
</properties>
</profile>


</profiles>

<build>
Expand All @@ -403,10 +413,10 @@
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.20.1</version>
<configuration>
<systemPropertyVariables>
<browser>${browser}</browser>
Expand All @@ -421,8 +431,6 @@
<arq.managementPort>${arq.managementPort}</arq.managementPort>
</systemPropertyVariables>
<argLine>${argLine}</argLine>
<groups>${test.included.category}</groups>
<excludedGroups>${mode.excluded.category},${test.excluded.category}</excludedGroups>
</configuration>
</plugin>

Expand Down Expand Up @@ -452,6 +460,7 @@
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<consoleOutput>true</consoleOutput>
<failsOnError>true</failsOnError>
<linkXRef>false</linkXRef>
<configLocation>checkstyle.xml</configLocation>
</configuration>
</execution>
Expand All @@ -476,7 +485,6 @@
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
Expand Down