added KnownIssue category, annotated known issues #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebrik
requested changes
Dec 8, 2017
pom.xml
Outdated
| @@ -354,6 +354,9 @@ | |||
| <test.included.category> | |||
| org.jboss.hal.testsuite.category.Elytron | |||
| </test.included.category> | |||
| <test.excluded.category> | |||
There was a problem hiding this comment.
We need to be able to choose if we want to run KnownIssue tests or not. This way of implementation excludes KnownIssues tests every time.
We rather need new profile which let us choose if we want to run them or not.
zebrik
requested changes
Dec 11, 2017
| <profile> | ||
| <id>withoutKnownIssues</id> | ||
| <properties> | ||
| <test.excluded.category> |
There was a problem hiding this comment.
There seems to be conflict of test.excluded.category property between noSecurity and withoutKnownIssues profiles. If you use them both it would be IMO overwritten.
added 2 commits
January 22, 2018 13:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.