[query] Remove BlockMatrix persist from Backend interface #14690
+105
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 17, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
92da6f0
to
4576acf
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
b0be25e
to
6038f9b
Compare
This was referenced Sep 20, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
4576acf
to
8a42e93
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
15f2275
to
71fcb35
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
341e6a7
to
1682964
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
71fcb35
to
360af7c
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
1682964
to
b1c0d04
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
360af7c
to
d16f9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is split out from a larger refactoring effort on the various Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a backend,
reduce code duplication and reduce state duplication.
In this change, I'm removing blockmatrix persist/unpersist from the
Backendinterface by adding
BlockMatrixCache: mutable.Map[String, BlockMatrix]toExecuteContext. The various reader/writer implementations simply fetch theblock matrix from this cache. For the spark backend, this is backed by a cache
whose lifetime is tied to the spark backend. Since block matrices are not
supported in the local and service backends, the cache is an empty map.
Note that block matrix persist is broken in python (#14689)