Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

Open
wants to merge 1 commit into
base: ehigham/http-like-rpc
Choose a base branch
from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 20, 2024

Refactored table reader coercion and caching mechanism.

What changed?

  • Removed shouldCacheQueryInfo method from Backend class
  • Introduced CoercerCache in ExecuteContext
  • Refactored LoweredTableReader.makeCoercer to return a function instead of a class
  • Removed local caching in GenericTableValue and LoweredTableReader
  • Added NoCaching utility

Why make this change?

This change aims to optimize table reader coercion by:

  • Centralizing caching logic in ExecuteContext
  • Allowing more flexible caching strategies across different backend implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant