Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCK-7301: try to fix missing dependency #117

Merged
merged 1 commit into from
Jul 19, 2024
Merged

HCK-7301: try to fix missing dependency #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions forward_engineering/helpers/columnDefinitionHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
const _ = require('lodash');
const templates = require('../configs/templates');

module.exports = app => {
const templates = require('../configs/templates');
const assignTemplates = app.require('@hackolade/ddl-fe-utils').assignTemplates;
const _ = app.require('lodash');
Copy link
Contributor

@bigorn0 bigorn0 Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nightlngale The idea was to progressively remove providing lodash from the app not to extend its usage. Isn't it a better way to use the installed version from the plugin? Here we have a hidden usage of a peerDependency from the app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially Lodash is part of the deps:

Snowflake/package.json

Line 56 in ac47339

"lodash": "4.17.21",


const decorateType = (type, columnDefinition) => {
type = _.toUpper(type);
Expand Down