HCK-7301: try to fix missing dependency #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nightlngale
commented
Jul 19, 2024
•
Nightlngale
commented
 HCK-7301 App crashes on SnowFlake target
|
|
chulanovskyi-bs
approved these changes
Jul 19, 2024
bigorn0
reviewed
Jul 19, 2024
| const assignTemplates = app.require('@hackolade/ddl-fe-utils').assignTemplates; | ||
| const _ = app.require('lodash'); |
There was a problem hiding this comment.
@Nightlngale The idea was to progressively remove providing lodash from the app not to extend its usage. Isn't it a better way to use the installed version from the plugin? Here we have a hidden usage of a peerDependency from the app.
There was a problem hiding this comment.
Especially Lodash is part of the deps:
Line 56 in ac47339
chulanovskyi-bs
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit ac47339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.