Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts a project to use centralised package management #398

Conversation

guibranco
Copy link
Owner

@guibranco guibranco commented May 26, 2024

Resolves #397


Before the change?

  • Package version on each csproj file

After the change?

  • Centralized package management via Directory.Packages.props

Pull request checklist

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

  • Yes
  • No

@guibranco guibranco linked an issue May 26, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2024
@guibranco guibranco enabled auto-merge (squash) May 26, 2024 23:53
@gstraccini gstraccini bot added the enhancement New feature or request label May 26, 2024
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@guibranco guibranco mentioned this pull request May 31, 2024
4 tasks
auto-merge was automatically disabled May 31, 2024 22:13

Pull request was closed

@guibranco guibranco reopened this May 31, 2024
@guibranco guibranco enabled auto-merge (squash) May 31, 2024 22:16
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
@guibranco guibranco closed this May 31, 2024
auto-merge was automatically disabled May 31, 2024 22:22

Pull request was closed

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.19% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c8c69d8) 3154 1355 42.96%
Head commit (3959e17) 3154 (+0) 1361 (+6) 43.15% (+0.19%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#398) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@AppVeyorBot
Copy link

@guibranco guibranco deleted the feature/397-feature-converts-a-project-to-use-centralised-package-management branch June 7, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Converts a project to use Centralised Package Management
3 participants