Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use centralized package management #406

Merged
merged 2 commits into from
May 31, 2024

Conversation

guibranco
Copy link
Owner

Resolves #398


Before the change?

  • Use the NuGet package version on each project file

After the change?

  • Use centralized package management via the Directory.Packages.props file.

Pull request checklist

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

  • Yes
  • No

@guibranco guibranco enabled auto-merge (squash) May 31, 2024 21:51
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.10% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a22c904) 3154 1358 43.06%
Head commit (e42a77a) 3154 (+0) 1361 (+3) 43.15% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#406) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AppVeyorBot
Copy link

@guibranco guibranco merged commit c8c69d8 into main May 31, 2024
27 checks passed
@guibranco guibranco deleted the feature/centralized-package-management branch May 31, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants