Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplePay & Payment Cards to Epic CTA's #988

Merged
merged 24 commits into from
Nov 8, 2023

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Oct 12, 2023

What does this change?

As part of the “one-click payment” exploration, we decided to build in the apple logo button and direct users to checkout to monitor click through rates (only). 2-step checkout test will be live at the same time, so no directing readers to any specific page of checkout required for now.

[Trello] https://trello.com/c/EFtKKTMB/1589-adding-apple-pay-logo-on-to-epics-development

ApplePay Setup Documentation (associated PR's)

Apple needs to authorise the guardian to display an Apple Pay logo button inside our Epic's on http://www.theguardian.com/ and https://m.code.dev-theguardian.com - a MerchantId file has been authorised and generated for use. Two (different pre-generated static) Apple merchantId files need to be located at the following paths:-
https://m.code.dev-theguardian.com/.well-known/apple-developer-merchantid-domain-association.txt
https://www.theguardian.com/.well-known/apple-developer-merchantid-domain-association.txt
Platform
Frontend

Setup Notes
ApplePay Check https://developer.apple.com/documentation/apple_pay_on_the_web/apple_pay_js_api/checking_for_apple_pay_availability
ApplePay MerchantId merchant.uk.co.guardian.contributions
ApplePay MerchantId Domain SetUp https://docs.subscribepro.com/integrations/magento-1/apple-pay/domain-verification/

Design

  • Triggered by any epic variant labeled 'V1-APPLE-PAY' AND ApplePay enabled in Safari
  • Storybook epics variant labeled 'V1-APPLE-PAY' AND 'forceApplePay' flag will force ApplePay display
  • Display ApplePay and Other Payments CTA's containing SVG's
  • Tablet and below breakpoint display extra Reminder CTA
  • Ophan logging (view and click)
Mobile Desktop
image image

How to test

  1. Storybook
  • All browsers regardless of ApplePay settings (ApplePay button displayed - for testing purposes)
  1. RRCP Dev/Code
  • Non-Safari Browser (original)
  • Safari Browser without ApplePay setup (original)
  • Safari Browser WITH ApplePay (ApplePay button displayed)

Accessibility test checklist

@paul-daniel-dempsey paul-daniel-dempsey changed the title intial wiring Add ApplePay & Payment Cards to Epic CTA's Oct 12, 2023
@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team October 19, 2023 09:07
…epic-applepay-authorised' event added, storybook test relabeled forceApplyPay, comments removed
@paul-daniel-dempsey paul-daniel-dempsey force-pushed the pd-epic-apple-pay branch 2 times, most recently from cb9aac2 to f19d717 Compare November 6, 2023 20:57
…om function to constant, ophan action corrected to view,
Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants