-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApplePay & Payment Cards to Epic CTA's #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-daniel-dempsey
changed the title
intial wiring
Add ApplePay & Payment Cards to Epic CTA's
Oct 12, 2023
paul-daniel-dempsey
force-pushed
the
pd-epic-apple-pay
branch
from
October 13, 2023 18:49
61607c4
to
1846a90
Compare
paul-daniel-dempsey
force-pushed
the
pd-epic-apple-pay
branch
from
October 13, 2023 19:17
f685c6c
to
bcee091
Compare
paul-daniel-dempsey
force-pushed
the
pd-epic-apple-pay
branch
from
October 18, 2023 15:41
9047652
to
56e9771
Compare
2 tasks
…epic-applepay-authorised' event added, storybook test relabeled forceApplyPay, comments removed
GHaberis
reviewed
Nov 3, 2023
packages/modules/src/modules/epics/ContributionsEpicButtons.tsx
Outdated
Show resolved
Hide resolved
GHaberis
reviewed
Nov 3, 2023
jamesgorrie
reviewed
Nov 6, 2023
paul-daniel-dempsey
force-pushed
the
pd-epic-apple-pay
branch
2 times, most recently
from
November 6, 2023 20:57
cb9aac2
to
f19d717
Compare
GHaberis
reviewed
Nov 7, 2023
GHaberis
reviewed
Nov 7, 2023
packages/modules/src/modules/epics/ContributionsEpicButtons.tsx
Outdated
Show resolved
Hide resolved
GHaberis
reviewed
Nov 7, 2023
…nt specificity corrected
paul-daniel-dempsey
force-pushed
the
pd-epic-apple-pay
branch
from
November 7, 2023 12:58
a36e34e
to
029f531
Compare
GHaberis
reviewed
Nov 7, 2023
GHaberis
reviewed
Nov 7, 2023
packages/modules/src/modules/epics/ContributionsEpicButtons.tsx
Outdated
Show resolved
Hide resolved
GHaberis
reviewed
Nov 7, 2023
…om function to constant, ophan action corrected to view,
GHaberis
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
As part of the “one-click payment” exploration, we decided to build in the apple logo button and direct users to checkout to monitor click through rates (only). 2-step checkout test will be live at the same time, so no directing readers to any specific page of checkout required for now.
[Trello] https://trello.com/c/EFtKKTMB/1589-adding-apple-pay-logo-on-to-epics-development
ApplePay Setup Documentation (associated PR's)
Apple needs to authorise the guardian to display an Apple Pay logo button inside our Epic's on
http://www.theguardian.com/
andhttps://m.code.dev-theguardian.com
- a MerchantId file has been authorised and generated for use. Two (different pre-generated static) Apple merchantId files need to be located at the following paths:-https://m.code.dev-theguardian.com/.well-known/apple-developer-merchantid-domain-association.txt
https://www.theguardian.com/.well-known/apple-developer-merchantid-domain-association.txt
Platform
Frontend
Design
How to test
Accessibility test checklist