Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ApplePay by adding merchand ID #26672

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Nov 2, 2023

What does this change?

Apple needs to authorise the guardian to display an Apple Pay logo button inside our Epic's on http://www.theguardian.com/ and https://m.code.dev-theguardian.com - a MerchantId file has been authorised and generated for use.

Two (different pre-generated static) Apple merchantId files need to be located at the following paths:-
https://m.code.dev-theguardian.com/.well-known/apple-developer-merchantid-domain-association
https://www.theguardian.com/.well-known/apple-developer-merchantid-domain-association

This is part of the “one-click payment” exploration, we decided to build in the apple logo button and direct users to checkout to monitor click through rates (only).
Trello

Associated PRs

Platform
Dotcom-Components

Testing Locally (Facia)

http://localhost:9000/.well-known/apple-developer-merchantid-domain-association

Checklist

  • Tested locally, and on CODE if necessary
  • Will not break dotcom-rendering

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team as a code owner November 2, 2023 09:47
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure the routes file’s diff is reduced to only the relevant parts?

Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – you probably want to squash your commits!

Have you checked that it works locally?

facia/conf/application.conf Outdated Show resolved Hide resolved
@paul-daniel-dempsey paul-daniel-dempsey changed the title MerchantId files add Enable ApplePay by adding merchand ID Nov 2, 2023
Copy link
Contributor

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@jamesgorrie
Copy link
Contributor

jamesgorrie commented Nov 3, 2023

As we need to serve assets conditionally, we've had to make the Assets controller available to the FaciaController.

It is odd that we've not seen this before, but a lot of the work to do that is wiring up the dependencies.

It does point to that we should probably not be relying on the facia controller to serve static text files. Maybe Fastly can help us here.

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @paul-daniel-dempsey 18 minutes and 38 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants