Add aspect ratio to frontend collection config #27621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
force-pushed
the
gl/aspect-ratio
branch
from
bcc1d27 to
83aefa9
Compare
Georges-GNM
force-pushed
the
gl/aspect-ratio
branch
from
b37dc84 to
b52515a
Compare
11 tasks
cemms1
approved these changes
Nov 21, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @Georges-GNM 13 minutes and 30 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @Georges-GNM 13 minutes and 44 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Part of this fairground ticket
Requires this DCR PR, as well as this facia-scala-client one which adds the logic to get the aspect ratio from the collection type. Once the facia scala client PR has been approved and the update released, I'll update this branch with the latest version of the library.
Supports aspectRatio as an optional property in the frontend collection config.
Deployed to code and, after relaunching the fairground front, checked we could see the value appear in the pressed json:
With the DCR PR, I could also see the expected value come through (rendered here through a div inserted on the front with the following:
<div>{collection.collectionType}, aspect ratio: {collection.aspectRatio}</div>