Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAspectRatio method to collection config #335

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Nov 18, 2024

What does this change?

Part of this fairground ticket

Adds logic in the collection config object to get the aspect ratio from the collection type. This will then be used by MAPI and frontend to pass the value through to the rendering platforms, saving us from having to hardcode it there.

Tested on web via these frontend and DCR PRs (and in fact this update being released is a prerequisite to using it in frontend).

How to test

For web, deploy the frontend branch using this preview release to code, then launch a front. You should then see in the pressed json for the page the new aspect ratio value coming through:

image

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@Georges-GNM Georges-GNM changed the title Add aspect ratio to resolved metatadata model Add getAspectRatio method to collection config Nov 19, 2024
@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #51, based on commit f7f1aab:

12.2.0-PREVIEW.glaspect-ratio.2024-11-19T1531.f7f1aaba

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/aspect-ratio

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

…lectionConfig object) and pass full collection config as parameter (and update test)
@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840:

13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0028.ecaf8409

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/aspect-ratio

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840:

13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0034.ecaf8409

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/aspect-ratio

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840:

13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0922.ecaf8409

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/aspect-ratio

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Georges-GNM Georges-GNM self-assigned this Nov 21, 2024
@Georges-GNM Georges-GNM marked this pull request as ready for review November 21, 2024 16:15
Copy link
Contributor

@waisingyiu waisingyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me, thanks @Georges-GNM !

@Georges-GNM Georges-GNM merged commit 231481c into main Nov 25, 2024
10 checks passed
@Georges-GNM Georges-GNM deleted the gl/aspect-ratio branch November 25, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants