-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getAspectRatio method to collection config #335
Conversation
@Georges-GNM has published a preview version of this PR with release workflow run #51, based on commit f7f1aab: 12.2.0-PREVIEW.glaspect-ratio.2024-11-19T1531.f7f1aaba Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command: gh workflow run release.yml --ref gl/aspect-ratio Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
f7f1aab
to
c4aa0d2
Compare
…lectionConfig object) and pass full collection config as parameter (and update test)
@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840: 13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0028.ecaf8409 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command: gh workflow run release.yml --ref gl/aspect-ratio Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840: 13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0034.ecaf8409 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command: gh workflow run release.yml --ref gl/aspect-ratio Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
@Georges-GNM has published a preview version of this PR with release workflow run #53, based on commit ecaf840: 13.1.0-PREVIEW.glaspect-ratio.2024-11-21T0922.ecaf8409 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the gl/aspect-ratio branch, or use the GitHub CLI command: gh workflow run release.yml --ref gl/aspect-ratio Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great to me, thanks @Georges-GNM !
What does this change?
Part of this fairground ticket
Adds logic in the collection config object to get the aspect ratio from the collection type. This will then be used by MAPI and frontend to pass the value through to the rendering platforms, saving us from having to hardcode it there.
Tested on web via these frontend and DCR PRs (and in fact this update being released is a prerequisite to using it in frontend).
How to test
For web, deploy the frontend branch using this preview release to code, then launch a front. You should then see in the pressed json for the page the new aspect ratio value coming through:
How can we measure success?
Have we considered potential risks?
Images
Accessibility
Deployment