Commercial bundle updater 0% test #27578
Merged
+56
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
force-pushed
the
jlk/commercial-bundle-fetcher
branch
from
0088f55 to
82d946c
Compare
Jakeii
force-pushed
the
jlk/commercial-bundle-fetcher
branch
from
0a2fd77 to
133db01
Compare
dskamiotis
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Just to clarify my understanding based on the PR description and the CommercialBundle.scala file: The frontend will fetch the commercial bundle URL from the parameter store and cache it, instead of using the version from package.json. The key in the parameter store will be updated by a Riff-Raff deploy in the commercial repo. Is this correct?
Overall, the changes look good to me. Approving the PR.
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @Jakeii 12 minutes and 15 seconds ago)
|
|
Seen on ADMIN-PROD (merged by @Jakeii 12 minutes and 24 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a 0% test that will fetch the commercial bundle url from parameter store and cache it for 1 minute instead of using the version from
package.json, the key in parameter store will be updated by a riff-raff deploy in the commercial repo (corresponding PR guardian/commercial#1693).Why
Deploying commercial at the moment is a very arduous process with poor developer experience, it requires adding a changeset, releasing a version, waiting 3 times for checks to run in the commercial repo (feature PR, version bump PR and on main). Then bumping the version here in frontend rebuilding and redeploying the entirety of this project just to change a script on the page.
We can use riff-raff and cloudformation to upload the commercial bundle to S3 and set a parameter store key with it's current hashed url, which frontend will can read, which will allow practically instant deploys!