add 0% test

guardian · Dec 4, 2024 · 82d946c · 82d946c
1 parent 1615451
commit 82d946c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/common/app/common/configuration.scala b/common/app/common/configuration.scala
@@ -521,6 +521,10 @@ class GuardianConfiguration extends GuLogging {
     lazy val prebidServerUrl =
       configuration.getStringProperty("commercial.prebid.server.url") getOrElse "http://localhost:8000"
 
+    lazy val overrideCommercialBundleUrl: Option[String] =
+      if (environment.isDev) configuration.getStringProperty("commercial.overrideCommercialBundleUrl")
+      else None
+
     def getBundlePath = configuration.getMandatoryStringProperty("commercial.bundlePath")
   }
 

diff --git a/common/app/experiments/Experiments.scala b/common/app/experiments/Experiments.scala
@@ -12,6 +12,7 @@ object ActiveExperiments extends ExperimentsDefinition {
   override val allExperiments: Set[Experiment] =
     Set(
       EuropeBetaFront,
+      CommercialBundleUpdater,
       DarkModeWeb,
     )
   implicit val canCheckExperiment: CanCheckExperiment = new CanCheckExperiment(this)
@@ -38,3 +39,12 @@ object DarkModeWeb
       sellByDate = LocalDate.of(2025, 1, 30),
       participationGroup = Perc0D,
     )
+
+object CommercialBundleUpdater
+    extends Experiment(
+      name = "commercial-bundle-updater",
+      description = "Enable the commercial bundle updater",
+      owners = Seq(Owner.withGithub("jakeii")),
+      sellByDate = LocalDate.of(2025, 1, 30),
+      participationGroup = Perc0B,
+    )
diff --git a/common/app/views/support/JavaScriptPage.scala b/common/app/views/support/JavaScriptPage.scala
@@ -14,6 +14,7 @@ import model.dotcomrendering.DotcomRenderingUtils.assetURL
 import play.api.mvc.RequestHeader
 import views.support.Commercial.isAdFree
 import common.CommercialBundle
+import experiments.{ActiveExperiments, CommercialBundleUpdater}
 
 object JavaScriptPage {
 
@@ -71,9 +72,14 @@ object JavaScriptPage {
 
     val ipsos = if (page.metadata.isFront) getScriptTag(page.metadata.id) else getScriptTag(page.metadata.sectionId)
 
-    def commercialBundleUrl = JsString(
-      CommercialBundle.getBundleUrl,
-    )
+    val commercialBundleUrl =
+      if (ActiveExperiments.isParticipating(CommercialBundleUpdater)(request))
+        JsString(CommercialBundle.getBundleUrl)
+      else
+        JsString(
+          Configuration.commercial.overrideCommercialBundleUrl
+            .getOrElse(assetURL("javascripts/commercial/graun.standalone.commercial.js")),
+        )
 
     javascriptConfig ++ config ++ commercialMetaData ++ journalismMetaData ++ Map(
       ("edition", JsString(edition.id)),