Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the Task runner’s Listr tasks to ESM #27262

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Turn the Task runner’s Listr tasks to ESM #27262

merged 4 commits into from
Jun 26, 2024

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jun 25, 2024

What is the value of this and can you measure success?

Enable the use of ESM-only libraries such as cpy@9 in our tasks.

What does this change?

  • convert CommonJS tasks to ESM and use the explicit .mjs extension
  • only check touched Scala files in validate-head
  • refactor config.mjs so it’s more sensible

Follow-up on #27260

@mxdvl mxdvl requested a review from a team as a code owner June 25, 2024 17:24
@mxdvl mxdvl mentioned this pull request Jun 25, 2024
Closed
abeddow91
abeddow91 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@abeddow91 abeddow91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! thanks for putting the time in to modernise this

@mxdvl mxdvl added this to the Health milestone Jun 26, 2024
Base automatically changed from mxdvl/listr-directly to main June 26, 2024 09:38
@mxdvl mxdvl force-pushed the mxdvl/task-runner-tasks-esm branch from 7eba4dc to bc0599d Compare June 26, 2024 09:39
@github-actions GitHub Actions
Copy link
Contributor

Deploy build 2260 of dotcom:frontend-all to CODE

All deployment options

From guardian/actions-riff-raff.

@mxdvl mxdvl merged commit 0f24f0e into main Jun 26, 2024
6 checks passed
@mxdvl mxdvl deleted the mxdvl/task-runner-tasks-esm branch June 26, 2024 09:57
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @mxdvl 11 minutes and 45 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @mxdvl 12 minutes ago)

@arelra
Copy link
Member

arelra commented Jun 26, 2024

fyi just noticed that make watch is broken:

Error: Cannot find module '../tools/compile-css'
Require stack:
- /Users/[user]/code/frontend-2/dev/watch.js

@mxdvl mxdvl mentioned this pull request Jun 26, 2024
Merged
@SiAdcock SiAdcock mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeddow91 abeddow91 abeddow91 approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
WebX Team
Archived in project
Milestone
Health
Development

Successfully merging this pull request may close these issues.
4 participants
@mxdvl @prout-bot @arelra @abeddow91