Order Euro 2024 spider chart like our print one #27218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
reviewed
Jun 12, 2024
| ZonedDateTime.of(2024, 6, 29, 17, 0, 0, 0, ZoneId.of("Europe/London")), // Match 38 | ||
| ZonedDateTime.of(2024, 6, 30, 17, 0, 0, 0, ZoneId.of("Europe/London")), // Match 40 | ||
| ZonedDateTime.of(2024, 7, 1, 20, 0, 0, 0, ZoneId.of("Europe/London")), // Match 41 | ||
| ZonedDateTime.of(2024, 7, 1, 17, 0, 0, 0, ZoneId.of("Europe/London")), // Match 42 | ||
| ZonedDateTime.of(2024, 6, 30, 20, 0, 0, 0, ZoneId.of("Europe/London")), // Match 39 |
There was a problem hiding this comment.
Switching line 217 and 218 would bring this in line to the print version
There was a problem hiding this comment.
Cannot be done! Game 39 is the "home" for the quarter-final, so the order has to stay as it is
There was a problem hiding this comment.
While that is correct, as we do not have control of the order of the resulting match – 39 is on top, 37 is on bottom – it would probably create more confusion:
In that spirit I think it’s best to keep as-is
7 tasks
domlander
approved these changes
Jun 12, 2024
mxdvl
changed the title
mxdvl
changed the title
|
Seen on ADMIN-PROD (merged by @mxdvl 10 minutes and 57 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @mxdvl 12 minutes and 1 second ago)
|
mxdvl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Less confusion for our football fans.
What does this change?
Reorder the matches so it matches our print wall chart, and the UEFA one.
Checklist