Order Euro 2024 spider chart (almost) correctly #27216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add visual documentation so future travellers can understand how the ordering maps to the actual wall chart
abeddow91
reviewed
Jun 12, 2024
Comment on lines
+208
to
+216
| // Round of 16 | ||
| // | ||
| // 1 ━┓ ┏━ 5 | ||
| // ┣━━━┓ ┏━━━┫ | ||
| // 2 ━┛ ┃ ┃ ┗━ 6 | ||
| // ┣━━━┫ | ||
| // 3 ━┓ ┃ ┃ ┏━ 7 | ||
| // ┣━━━┛ ┗━━━┫ | ||
| // 4 ━┛ ┗━ 8 |
abeddow91
approved these changes
Jun 12, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @mxdvl 11 minutes and 2 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @mxdvl 11 minutes and 9 seconds ago)
|
7 tasks
|
The semi-finals are still wrong, fix in #27218 |
mxdvl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
The Euro 2024 web spider chart is correctly ordered.
What does this change?
Screenshots
Checklist