Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #26675

Closed
wants to merge 4 commits into from
Closed

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #26675

wants to merge 4 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 6, 2023

What is the value of this and can you measure success?

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

What does this change?

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 tools/**/*.js

Screenshots

N/A

Checklist

@trivikr trivikr marked this pull request as ready for review November 6, 2023 05:14
@trivikr trivikr requested a review from a team as a code owner November 6, 2023 05:14
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR @trivikr!

We’ll double-check wether this service is still in use before merging the change, it might be a part of our estate we can deprecate.

Are you happy for us to address the small issues I raised by pushing to your branch, or would you want to fix them yourself?

package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants