-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate AWS SDK for JavaScript v2 APIs to v3 #9411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
chore: run codemod on apps-rendering/**/*.ts
chore: migrate AWS SDK for JavaScript v2 APIs to v3
Nov 6, 2023
mxdvl
reviewed
Nov 6, 2023
mxdvl
added
Dependencies
Pull requests that update a dependency file
run_chromatic
Runs chromatic when label is applied
labels
Nov 13, 2023
mxdvl
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I’m pushing a draft PR that should kick off CI in #9613
mxdvl
reviewed
Nov 22, 2023
mxdvl
reviewed
Nov 23, 2023
This reverts commit 28b0487.
Transformation of aws-sdk/lib/core is not supported aws/aws-sdk-js-codemod#690
I’ll merge this tomorrow morning UK time so we’re around to catch any production errors. Thanks for your contributions @trivikr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apps-rendering
Dependencies
Pull requests that update a dependency file
run_chromatic
Runs chromatic when label is applied
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.
$ npx [email protected] -t v2-to-v3 apps-rendering/**/*.ts
Why?
From AWS SDK for JavaScript v2 README:
Similar to guardian/frontend#26675