Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #9411

Merged
merged 12 commits into from
Nov 24, 2023
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #9411

merged 12 commits into from
Nov 24, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 6, 2023

What does this change?

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 apps-rendering/**/*.ts

Why?

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Similar to guardian/frontend#26675

@trivikr trivikr changed the title chore: run codemod on apps-rendering/**/*.ts chore: migrate AWS SDK for JavaScript v2 APIs to v3 Nov 6, 2023
@trivikr trivikr marked this pull request as ready for review November 6, 2023 16:11
@trivikr trivikr requested a review from a team as a code owner November 6, 2023 16:11
apps-rendering/package.json Outdated Show resolved Hide resolved
@mxdvl mxdvl added Dependencies Pull requests that update a dependency file run_chromatic Runs chromatic when label is applied labels Nov 13, 2023
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I’m pushing a draft PR that should kick off CI in #9613

@mxdvl
Copy link
Contributor

mxdvl commented Nov 23, 2023

I’ll merge this tomorrow morning UK time so we’re around to catch any production errors.

Thanks for your contributions @trivikr!

@mxdvl mxdvl merged commit 09833a9 into guardian:main Nov 24, 2023
33 of 36 checks passed
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps-rendering Dependencies Pull requests that update a dependency file run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants