Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Article Share Counts #26611

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Deprecate Article Share Counts #26611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions applications/app/AppLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ trait ApplicationsServices {
lazy val siteMapJob = wire[SiteMapJob]
lazy val sectionsLookUp = wire[SectionsLookUp]
lazy val ophanApi = wire[OphanApi]
lazy val facebookGraphApiClient = wire[FacebookGraphApiClient]
lazy val facebookGraphApi = wire[FacebookGraphApi]
lazy val newsletterApi = wire[NewsletterApi]
lazy val newsletterSignupAgent = wire[NewsletterSignupAgent]
}
Expand Down
3 changes: 0 additions & 3 deletions applications/app/controllers/ApplicationsControllers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ import jobs.SiteMapJob
import model.ApplicationContext
import play.api.libs.ws.WSClient
import play.api.mvc.ControllerComponents
import services.FacebookGraphApi

trait ApplicationsControllers {

def contentApiClient: ContentApiClient
def siteMapJob: SiteMapJob
def sectionsLookUp: SectionsLookUp
def wsClient: WSClient
def facebookGraphApi: FacebookGraphApi
def controllerComponents: ControllerComponents
implicit def appContext: ApplicationContext

Expand All @@ -38,7 +36,6 @@ trait ApplicationsControllers {
lazy val shortUrlsController = wire[ShortUrlsController]
lazy val indexController = wire[IndexController]
lazy val siteVerificationController = wire[SiteVerificationController]
lazy val shareCountController = wire[ShareCountController]
lazy val youtubeController = wire[YoutubeController]
lazy val nx1ConfigController = wire[Nx1ConfigController]

Expand Down
27 changes: 0 additions & 27 deletions applications/app/controllers/ShareCountController.scala
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions applications/app/services/FacebookGraphApi.scala
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions applications/conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ GET /embed/atom/:atomType/:id/nojs/scroll-y
POST /story-questions/answers/signup controllers.AtomPageController.signup()
OPTIONS /story-questions/answers/signup controllers.AtomPageController.options()

# Share counts
GET /sharecount/*path.json controllers.ShareCountController.fetch(path)

# Preferences
GET /preferences controllers.PreferencesController.indexPrefs()

Expand Down
28 changes: 0 additions & 28 deletions applications/test/helpers/FacebookGraphApiTestClient.scala
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions applications/test/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package test

import java.util.{List => JList}
import org.scalatest.Suites
import services.{FacebookGraphApiTest, IndexPageTest, InteractivePickerTest, NewspaperControllerTest}
import services.{IndexPageTest, InteractivePickerTest, NewspaperControllerTest}

import scala.jdk.CollectionConverters._

Expand Down Expand Up @@ -40,7 +40,6 @@ class ApplicationsTestSuite
new CrosswordDataTest,
new NewspaperControllerTest,
new IndexPageTest,
new FacebookGraphApiTest,
new InteractivePickerTest,
)
with SingleServerSuite {}
31 changes: 0 additions & 31 deletions applications/test/services/FacebookGraphApiTest.scala
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dev-build/conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ GET /opt/reset
GET /sitemaps/news.xml controllers.SiteMapController.renderNewsSiteMap()
GET /sitemaps/video.xml controllers.SiteMapController.renderVideoSiteMap()
GET /$path<[\w\d-]*(/[\w\d-]*)+>/$file<interactive(-service)?-worker.js> controllers.InteractiveController.proxyInteractiveWebWorker(path, file)
GET /sharecount/*path.json controllers.ShareCountController.fetch(path)

GET /preferences controllers.PreferencesController.indexPrefs()
GET /embed/video/*path controllers.EmbedController.render(path)
Expand Down
2 changes: 0 additions & 2 deletions preview/conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ GET /$path<[\w\d-]*(/[\w\d-]*)?/(cartoon|graphic|picture)/.*>.json

GET /$path<[\w\d-]*(/[\w\d-]*)?/(interactive|ng-interactive)/.*>.json controllers.InteractiveController.renderInteractiveJson(path)

GET /sharecount/*path.json controllers.ShareCountController.fetch(path)

# Email paths
GET /email/form/$emailType<plain|plaindark|plaintone>/$listId<[0-9]+> controllers.EmailSignupController.renderForm(emailType: String, listId: Int)
GET /email/form/$emailType<plain|plaindark|plaintone>/:listName controllers.EmailSignupController.renderFormFromName(emailType: String, listName: String)
Expand Down