Deprecate Article Share Counts #26611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #26568. This feature is broken, and the feature switch has been off for some time.
georgeblahblah
added a commit
to guardian/dotcom-rendering
that referenced
this pull request
Sep 29, 2023
We are deprecating the share counts feature as part of guardian/frontend#26568. This change: - removes usages `serverShareCounts` switch - removes the `showShareCounts` property on the `ArticleMeta` component - deletes the `ShareCount` island component. We only rendered this when `serverShareCounts` switch was on - deletes the `Counts` component, and inlines this layout directly into `ArticleMeta` - removes palette entries for share counts There is a related change in Frontend: guardian/frontend#26611
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @georgeblahblah 18 minutes ago)
|
|
Seen on FRONTS-PROD (merged by @georgeblahblah 18 minutes and 9 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is broken, and the feature switch has been off for some time. We decided to deprecate it in #26568.
This change:
ShareCountsswitchShareCountsControllerFacebookGraphApiandFacebookGraphApiClientclassesThere is a related change in DCR: guardian/dotcom-rendering#8942