Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Akka to Pekko #26563

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Conversation

DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Sep 6, 2023

What is the value of this and can you measure success?

Replaces explicit uses of Akka with Pekko equivalent. To bring us in line with licensing requirements and allow us to continue receiving security patches.

I have left akka.stream.Materializer as from the doc seems like we might be able to continue using these

What does this change?

Resolves guardian/dotcom-rendering#8783

Checklist

@DanielCliftonGuardian DanielCliftonGuardian changed the title Akka migration - Migrate ActorSystem to pekko Migrate from Akka to Pekko Sep 8, 2023
@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review September 8, 2023 13:01
cemms1

This comment was marked as outdated.

Create PekkoActorSystem

Co-Authored-By: Jamie B <[email protected]>
Co-Authored-By: Charlotte Emms <[email protected]>
Co-Authored-By: Ioanna Kokkini <[email protected]>
Co-Authored-By: Ashleigh Carr <[email protected]>
Co-Authored-By: Parisa Tork <[email protected]>
@cemms1
Copy link
Contributor

cemms1 commented Sep 11, 2023

This is looking really good! 🚀

I think we're still missing a few uses of the old Akka system though (running dev-build on this branch locally highlights an old usage, for instance)

Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't totally consistent with naming the ActorSystem across the repo, so it might be better to reference it in the same way everywhere for better readability.

Not blocking though. If this works on CODE and locally then go for it 🚀

admin/test/services/ParameterStoreServiceTest.scala Outdated Show resolved Hide resolved
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @DanielCliftonGuardian 18 minutes and 8 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @DanielCliftonGuardian 20 minutes and 24 seconds ago)

@mkurz
Copy link
Contributor

mkurz commented Nov 7, 2023

See

for migrating to Play 3 which comes with Pekko now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Akka migration
5 participants