-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Akka to Pekko #26563
Migrate from Akka to Pekko #26563
Conversation
Create PekkoActorSystem Co-Authored-By: Jamie B <[email protected]> Co-Authored-By: Charlotte Emms <[email protected]> Co-Authored-By: Ioanna Kokkini <[email protected]> Co-Authored-By: Ashleigh Carr <[email protected]> Co-Authored-By: Parisa Tork <[email protected]>
aa1b643
to
003f097
Compare
This is looking really good! 🚀 I think we're still missing a few uses of the old Akka system though (running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't totally consistent with naming the ActorSystem
across the repo, so it might be better to reference it in the same way everywhere for better readability.
Not blocking though. If this works on CODE
and locally then go for it 🚀
Seen on ADMIN-PROD (merged by @DanielCliftonGuardian 18 minutes and 8 seconds ago)
|
Seen on FRONTS-PROD (merged by @DanielCliftonGuardian 20 minutes and 24 seconds ago)
|
See for migrating to Play 3 which comes with Pekko now. |
What is the value of this and can you measure success?
Replaces explicit uses of Akka with Pekko equivalent. To bring us in line with licensing requirements and allow us to continue receiving security patches.
I have left akka.stream.Materializer as from the doc seems like we might be able to continue using these
What does this change?
Resolves guardian/dotcom-rendering#8783
Checklist