-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(akka): update config and refactor names #26602
Conversation
Looks great!! 💎 Just one clarification for a few
I remember from #26563 we don't need to migrate those, is that correct?
|
akka.stream.materializer is proving difficult as we are using it in all the filters and it extends frontend/common/app/http/Filters.scala Line 23 in e93bc21
2. Good spot. This seems to just be disabling the use of the PlayAkkaHttpServer as we use the PlayNettyServer so i think we want to leave this https://github.com/guardian/frontend/blob/e93bc211dc6dd2350e9c6bb5c591531afef32426/project/ProjectSettings.scala#L121C7-L121C42 |
Thanks! Makes sense. Re the Materializer, perhaps you could add a similar comment. Looks like both of this points will be addressed in Play 3.0. Great work! |
Seen on FRONTS-PROD (merged by @DanielCliftonGuardian 17 minutes and 59 seconds ago)
|
Seen on ADMIN-PROD (merged by @DanielCliftonGuardian 18 minutes and 7 seconds ago)
|
See for migrating to Play 3 which comes with Pekko now. |
What is the value of this and can you measure success?
Part of Akka migration due to licensing changes (#8783)
Note: still using akka (instead of pekko) materializer from Play as both filters extend Play's Filter, so the types need to match
What does this change?
Updates config for akka to pekko as mentioned in the Pekko migration guide
Also renames
akkaAsync
values topekkoAsync
to make it super clear it's using Pekko not Akka now.This completes the work from #26582
Checklist