Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated keyIdentifier #14312

Merged
merged 2 commits into from
Sep 15, 2016
Merged

Remove deprecated keyIdentifier #14312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665d328
Remove deprecated keyIdentifier
mchv Sep 15, 2016
d941888
Add comment with upstream issue link
mchv Sep 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/src/javascripts/components/bean/bean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
* Bean - copyright (c) Jacob Thornton 2011-2012
* https://github.com/fat/bean
* MIT license
*
* Changes from upstream:
* - Removed 'keyIdentitfier' until https://github.com/fat/bean/issues/128 is fixed
*
*/
(function (name, context, definition) {
if (typeof module != 'undefined' && module.exports) module.exports = definition()
Expand Down Expand Up @@ -106,7 +110,7 @@
'fromElement offsetX offsetY pageX pageY screenX screenY toElement'))
, mouseWheelProps = mouseProps.concat(str2arr('wheelDelta wheelDeltaX wheelDeltaY wheelDeltaZ ' +
'axis')) // 'axis' is FF specific
, keyProps = commonProps.concat(str2arr('char charCode key keyCode keyIdentifier ' +
, keyProps = commonProps.concat(str2arr('char charCode key keyCode ' +
Copy link
Contributor

@gtrufitt gtrufitt Sep 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think until the issue is fixed in Bean this is the only thing we can do. Can you add a comment to this PR? 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry updated the link in PR description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this library in membership as well, it might be worth pushing this upstream or just plain forking it before we diverge further.

'keyLocation location'))
, textProps = commonProps.concat(str2arr('data'))
, touchProps = commonProps.concat(str2arr('touches targetTouches changedTouches scale rotation'))
Expand Down