Remove deprecated keyIdentifier #14312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyIdentifier is a deprecated property that will be removed from Chrome in September
|
👍 |
gtrufitt
approved these changes
Sep 15, 2016
| @@ -106,7 +106,7 @@ | |||
| 'fromElement offsetX offsetY pageX pageY screenX screenY toElement')) | |||
| , mouseWheelProps = mouseProps.concat(str2arr('wheelDelta wheelDeltaX wheelDeltaY wheelDeltaZ ' + | |||
| 'axis')) // 'axis' is FF specific | |||
| , keyProps = commonProps.concat(str2arr('char charCode key keyCode keyIdentifier ' + | |||
| , keyProps = commonProps.concat(str2arr('char charCode key keyCode ' + | |||
There was a problem hiding this comment.
Yes, I think until the issue is fixed in Bean this is the only thing we can do. Can you add a comment to this PR? 👍
There was a problem hiding this comment.
Sorry updated the link in PR description
There was a problem hiding this comment.
We use this library in membership as well, it might be worth pushing this upstream or just plain forking it before we diverge further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove
keyIdentifieras a property frombean.jsas this is now deprecated and will be removed soon.Currently console display a warning on every page:
As
bean.jsseems to be copied, I don't know if we should diverge or wait for the upstream issue being fixed and then update to the latest version.What is the value of this and can you measure success?
Prevent breaking frontend (throwing an client side error potentially breaking other features) when latest
chromewill removekeyIdentifier.Does this affect other platforms - Amp, Apps, etc?
keyIdentifierdoes not seems to be used onfrontendso I don't think it should break anything or anyone.