Code

Add multi byline element#12496

Code

Merged

simonbyford merged 51 commits intomainguardian/dotcom-rendering:mainfrom rm/add-multi-bylineguardian/dotcom-rendering:rm/add-multi-bylineCopy head branch name to clipboardJan 6, 2025

+1,077-112

Commits

Commits on Jan 6, 2025

• Add foundation for multi-byline element, based on mini-profiles

  

  rhystmills

  authored and

  simonbyford

  committed
  69f0ac4

• Add Story for multi byline element and update model to include byline and bylineHtml

  

  rhystmills

  authored and

  simonbyford

  committed
  5132540

• Show a byline in the multi-byline element

  

  rhystmills

  authored and

  simonbyford

  committed
  6e33d0d

• Improve styles on Multi byline element

  

  rhystmills

  authored and

  simonbyford

  committed
  7ec9ebd

• Push pending changes

  

  rhystmills

  authored and

  simonbyford

  committed
  efed52a

• fix import errors following #12461 and #12566

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  ffb2f18

• fix eslint errors

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  465761d

• fix stylelint errors

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  7c5c88e

• style contributor names that don't have a corresponding tag

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  8e67059

• add stories for opinion and culture pillars

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  df848f3

• byline image styling

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  2d026ba

• add multi-bylines to DCR model

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  2b3ac4f

• retrieve image url from contributor tag

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  014dbed

• run 'make gen-schema'

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  b89df84

• add end note to component

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  f174743

• replace img tag with Avatar component

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  bfb00cb

• update bottom margin to match designs

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  ffaf65a

• fix css linting

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  562ba95

• filter out audio designs in stories

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  26756cf

• tidy up labs-specific styling and remove !important to keep linter happy.

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  978453b

• make stories shorter to fix chromatic build

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  44502c3

• break up design stories to fix chromatic build

  

  rebecca-thompson

  authored and

  simonbyford

  committed
  31f8401

• Break out EndNote into its own component

  simonbyford

  committed
  1a45c1a

• Break out Bio into its own component

  simonbyford

  committed
  a580b78

• Remove unused exports

  simonbyford

  committed
  4ae9daf

• Remove unnecessary fragment

  simonbyford

  committed
  bf15345

• Remove irrelevant comments

  simonbyford

  committed
  68d5095

• Don't skip h2

  simonbyford

  committed
  31ebb39

• Multi-byline articles are not ordered lists

  simonbyford

  committed
  d30fded

• Make byline, bylineHtml, contributorIds required

  simonbyford

  committed
  384f334

• Remove redundancy in stories file

  simonbyford

  committed
  c1a614a

• Be consistent in how we reuse args

  simonbyford

  committed
  95daefb

• Use colour from palette for bottom separator

  simonbyford

  committed
  c5f7d38

• Add bottom separator to Q and A Explainer element

  simonbyford

  committed
  76e8ed2

• Lint

  simonbyford

  committed
  894ca06

• Fix schema

  simonbyford

  committed
  c85c3b0

• Disable amp

  simonbyford

  committed
  c59dfd8

• Support list of contents

  simonbyford

  committed
  b522e05

• Timeline doesn't need tags

  simonbyford

  committed
  86173e2

• Rename colours

  simonbyford

  committed
  28236e4

• Add new colour --bio-link-underline

  simonbyford

  committed
  3914352

• Use bylineImageUrl not bylineLargeImageUrl

  simonbyford

  committed
  fbca108

• Add new colour --multi-byline-non-linked-text

  simonbyford

  committed
  138e7e9

• Use typography presets

  simonbyford

  committed
  cb01858

• Lint

  simonbyford

  committed
  cb86c1b

• Remove redundant styles

  simonbyford

  committed
  6ef8291

• Simplify naming

  simonbyford

  committed
  7d99004

• Use hgroup instead of h3 to better follow spec

  simonbyford

  committed
  0f41a1d

• Derive imageUrl in the enhancer

  simonbyford

  committed
  1d0dab1

• Skip elements without a byline or bylineHtml

  simonbyford

  committed
  8ffa626

• Remove unused import

  simonbyford

  committed
  ad506b0