Add multi byline element #12496
Merged
Add multi byline element #12496
+1,077
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +41 B (0%) Total Size: 931 kB ℹ️ View Unchanged
|
rebecca-thompson
force-pushed
the
rm/add-multi-byline
branch
from
6f2a23a to
48839af
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
JamieB-gu
reviewed
Nov 12, 2024
SiAdcock
reviewed
Nov 12, 2024
Your thorough review is very much appreciated, I'm going to start looking through these shortly |
simonbyford
force-pushed
the
rm/add-multi-byline
branch
from
2d1f11f to
fd85545
Compare
simonbyford
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Hey @JamieB-gu and @SiAdcock, thanks again for your thorough review of this work. I've pushed some changes in response to your comments. Would you mind having another look and marking comments as "resolved" where you are satisfied, or replying where you are not?
There are a few outstanding comments which require input from design which I haven't addressed yet. I'll keep you posted on these.
JamieB-gu
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Hey @JamieB-gu and @SiAdcock, thanks again for your thorough review of this work. I've pushed some changes in response to your comments. Would you mind having another look and marking comments as "resolved" where you are satisfied, or replying where you are not?
There are a few outstanding comments which require input from design which I haven't addressed yet. I'll keep you posted on these.
Thanks, looks good! I've gone through and resolved everything that's been updated, but left the comments that have outstanding design questions, as you mention.
simonbyford
force-pushed
the
rm/add-multi-byline
branch
from
115bf26 to
cabfb8f
Compare
simonbyford
force-pushed
the
rm/add-multi-byline
branch
2 times, most recently
from
942a0ae to
69805ce
Compare
simonbyford
force-pushed
the
rm/add-multi-byline
branch
from
15fa7b9 to
ad506b0
Compare
|
Seen on PROD (created by @rhystmills and merged by @simonbyford 7 minutes and 32 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds the rendering logic for the Multi-byline element.
This is a variant of the
Listelement from CAPI, in addition to the Key Takeaways, Q&A and Mini Profiles elements, which are rendered by DCR.The designs for this element can be found here: https://www.figma.com/design/TK4X89VBAIZ65zmIqApOkI/Formats-%E2%80%94-Structured-elements?node-id=5-165675&t=Fm8oqMKrRoOKTHyp-1
Why?
MultiBylinesare one of a number of new structure articles formats that Content Production have been developing which needs to be supported by our website.Screenshots